You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/26 14:01:47 UTC

[GitHub] [airflow] mik-laj commented on issue #12639: AWS hook: Allow retries for assume_role_with_saml on HTTP failures with IDP request

mik-laj commented on issue #12639:
URL: https://github.com/apache/airflow/issues/12639#issuecomment-734314872


   @baolsen  We commonly use tenacity. 
   
   It would be fantastic if you could rewrite the code to use AssumeRoleCredentialFetcher to handle credential expiration as well. Currently, the STS token is valid for only one hour and after that time it expires and Airflow does not try to obtain a new token.
   https://github.com/boto/botocore/blob/6e3ec4e8544ea32e130ac42b414a2819627c475b/botocore/credentials.py#L758
   Here is an example for GCP authorization
   https://github.com/apache/airflow/blob/master/airflow/providers/amazon/aws/hooks/base_aws.py#L271-L281


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org