You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/01/03 11:03:46 UTC

[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #1: using StringBuilder instead of StringBuffer

Technoboy- opened a new pull request #1: using StringBuilder instead of StringBuffer
URL: https://github.com/apache/incubator-tubemq/pull/1
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] Technoboy- commented on issue #1: using StringBuilder instead of StringBuffer

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1: using StringBuilder instead of StringBuffer
URL: https://github.com/apache/incubator-tubemq/pull/1#issuecomment-571401945
 
 
   > @Technoboy- Can you pull a issue first and include the issue-id in the PR name?
   
   But where is the issue tag ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] TisonKun commented on issue #1: using StringBuilder instead of StringBuffer

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #1: using StringBuilder instead of StringBuffer
URL: https://github.com/apache/incubator-tubemq/pull/1#issuecomment-571405283
 
 
   @Technoboy- Yes it could be a choice. Actually the community has discussed about this before[1]. You can participant the discussion or start a new thread, and share your idea. The community might switch to GitHub issue if there is a convincing reason.
   
   [1] https://lists.apache.org/x/thread.html/b1d46bd289d38bdd2f27fff2af7dba879fc53767b536b4ca9a6cdcf6@%3Cdev.tubemq.apache.org%3E

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] TisonKun commented on issue #1: using StringBuilder instead of StringBuffer

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #1: using StringBuilder instead of StringBuffer
URL: https://github.com/apache/incubator-tubemq/pull/1#issuecomment-571403425
 
 
   > > @Technoboy- Can you pull a issue first and include the issue-id in the PR name?
   > 
   > But where is the issue tag ?
   
   https://issues.apache.org/jira/projects/TUBEMQ/issues
   
   @Technoboy- TubeMQ uses JIRA as issue tracker. Hopefully we will have a CONTRIBUTE guide soon later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] gosonzhang commented on issue #1: using StringBuilder instead of StringBuffer

Posted by GitBox <gi...@apache.org>.
gosonzhang commented on issue #1: using StringBuilder instead of StringBuffer
URL: https://github.com/apache/incubator-tubemq/pull/1#issuecomment-571399807
 
 
   @Technoboy- Can you pull a issue first and include the issue-id in the PR name?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] Technoboy- commented on issue #1: using StringBuilder instead of StringBuffer

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1: using StringBuilder instead of StringBuffer
URL: https://github.com/apache/incubator-tubemq/pull/1#issuecomment-571410868
 
 
   All right , I will create a JIRA issue later. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] TisonKun merged pull request #1: TUBEMQ-7: Using StringBuilder instead of StringBuffer in BaseResult

Posted by GitBox <gi...@apache.org>.
TisonKun merged pull request #1: TUBEMQ-7: Using StringBuilder instead of StringBuffer in BaseResult
URL: https://github.com/apache/incubator-tubemq/pull/1
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] TisonKun commented on issue #1: using StringBuilder instead of StringBuffer

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #1: using StringBuilder instead of StringBuffer
URL: https://github.com/apache/incubator-tubemq/pull/1#issuecomment-571405673
 
 
   BTW, the Apache way says all discussions happens on mailing list, so it is highly recommended to subscribe the mailing list[1] and discuss anything you want to.
   
   [1] mailto:dev-subscribe@tubemq.apache.org

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] TisonKun commented on issue #1: TUBEMQ-7: Using StringBuilder instead of StringBuffer in BaseResult

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #1: TUBEMQ-7: Using StringBuilder instead of StringBuffer in BaseResult
URL: https://github.com/apache/incubator-tubemq/pull/1#issuecomment-571473651
 
 
   Thanks for your contribution @Technoboy- !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] Technoboy- commented on issue #1: using StringBuilder instead of StringBuffer

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1: using StringBuilder instead of StringBuffer
URL: https://github.com/apache/incubator-tubemq/pull/1#issuecomment-571404407
 
 
   > > > @Technoboy- Can you pull a issue first and include the issue-id in the PR name?
   > > 
   > > 
   > > But where is the issue tag ?
   > 
   > https://issues.apache.org/jira/projects/TUBEMQ/issues
   > 
   > @Technoboy- TubeMQ uses JIRA as issue tracker. Hopefully we will have a CONTRIBUTE guide soon later.
   
   How about using github ?  It's more convenient for user. 
   As many projects start with JIRA, but change to github in the end. like "Apache Helix"
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] TisonKun commented on issue #1: using StringBuilder instead of StringBuffer

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #1: using StringBuilder instead of StringBuffer
URL: https://github.com/apache/incubator-tubemq/pull/1#issuecomment-571403596
 
 
   @Technoboy- Here is a guide how to file an issue on JIRA https://confluence.atlassian.com/jiracoreserver073/creating-issues-and-sub-tasks-861257329.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services