You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2018/11/13 04:09:32 UTC
Remove deprecated classes in master
Hello All,
I noticed there are some classes deprecated in 8.2.0 which exists in 9.0.0
(For example org.apache.wicket.util.crypt.Base64)
I would like to remove them
Are there any objections?
--
WBR
Maxim aka solomax
Re: Remove deprecated classes in master
Posted by Tobias Soloschenko <to...@googlemail.com.INVALID>.
Base64 can easily be replaced with (Java 8)
// Encode
String asB64 = Base64.getEncoder().encodeToString("some string".getBytes("utf-8"));
System.out.println(asB64); // Output will be: c29tZSBzdHJpbmc=
// Decode
byte[] asBytes = Base64.getDecoder().decode("c29tZSBzdHJpbmc=");
System.out.println(new String(asBytes, "utf-8")); // And the output is: some string
So for me +1 for removal. I don’t know about the other classes - maybe we need to discuss one by one.
kind regards
Tobias
> Am 13.11.2018 um 05:09 schrieb Maxim Solodovnik <so...@gmail.com>:
>
> Hello All,
>
> I noticed there are some classes deprecated in 8.2.0 which exists in 9.0.0
> (For example org.apache.wicket.util.crypt.Base64)
>
> I would like to remove them
>
> Are there any objections?
>
> --
> WBR
> Maxim aka solomax
Re: Remove deprecated classes in master
Posted by Martin Grigorov <ma...@gmail.com>.
On Sat, Nov 24, 2018, 12:03 Maxim Solodovnik <solomax666@gmail.com wrote:
> Hello All,
>
> I'll try to list all @Deprecated classes/methods with some history.
>
> There are 118 blocks marked as Duplicated
>
> I believe those marked as `@Deprecated(since = "8.0", forRemoval = true)`
> can be removed (8 entries)
>
> Following blocks were @Deprecated in both wicket7 and wicket8
> org.apache.wicket.core.util.lang.WicketObjects.cloneModel(T)
> org.apache.wicket.markup.html.form.FormComponent.onRequired(ComponentTag)
>
> org.apache.wicket.markup.resolver.HtmlHeaderResolver.newHtmlHeaderContainer(String)
> org.apache.wicket.markup.WicketTag.getNameAttribute()
> org.apache.wicket.migrate.StringResourceModelMigration.of(String,
> Component, IModel<?>, Object...)
> org.apache.wicket.migrate.StringResourceModelMigration.of(String,
> Component, IModel<?>, String, Object...)
> org.apache.wicket.migrate.StringResourceModelMigration.of(String,
> IModel<?>, Object...)
> org.apache.wicket.migrate.StringResourceModelMigration.of(String,
> IModel<?>, String, Object...)
>
> org.apache.wicket.protocol.http.mock.MockHttpServletRequest.getRealPath(String)
> .......................................
>
> So I propose to
> 1) Drop all `@Deprecated(since = "8.0", forRemoval = true)` from master
> 2) Drop all marked as @Deprecated in wicket7 from both wicket8 and master
> (or at least from master)
>
+1 to remove both 1) and 2) from master only
> Can I?
>
>
>
> On Tue, 13 Nov 2018 at 13:47, Martin Grigorov <mg...@apache.org>
> wrote:
>
> > Hi Maxim,
> >
> > Anything that is deprecated and has "WIll be removed in Wicket 9" could
> be
> > removed.
> > But there are some classes which are deprecated in 9 but should be
> removed
> > in 10.
> >
> > On Tue, Nov 13, 2018 at 6:09 AM Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> > > Hello All,
> > >
> > > I noticed there are some classes deprecated in 8.2.0 which exists in
> > 9.0.0
> > > (For example org.apache.wicket.util.crypt.Base64)
> > >
> > > I would like to remove them
> > >
> > > Are there any objections?
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
>
>
> --
> WBR
> Maxim aka solomax
>
Re: Remove deprecated classes in master
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello All,
I'll try to list all @Deprecated classes/methods with some history.
There are 118 blocks marked as Duplicated
I believe those marked as `@Deprecated(since = "8.0", forRemoval = true)`
can be removed (8 entries)
Following blocks were @Deprecated in both wicket7 and wicket8
org.apache.wicket.core.util.lang.WicketObjects.cloneModel(T)
org.apache.wicket.markup.html.form.FormComponent.onRequired(ComponentTag)
org.apache.wicket.markup.resolver.HtmlHeaderResolver.newHtmlHeaderContainer(String)
org.apache.wicket.markup.WicketTag.getNameAttribute()
org.apache.wicket.migrate.StringResourceModelMigration.of(String,
Component, IModel<?>, Object...)
org.apache.wicket.migrate.StringResourceModelMigration.of(String,
Component, IModel<?>, String, Object...)
org.apache.wicket.migrate.StringResourceModelMigration.of(String,
IModel<?>, Object...)
org.apache.wicket.migrate.StringResourceModelMigration.of(String,
IModel<?>, String, Object...)
org.apache.wicket.protocol.http.mock.MockHttpServletRequest.getRealPath(String)
.......................................
So I propose to
1) Drop all `@Deprecated(since = "8.0", forRemoval = true)` from master
2) Drop all marked as @Deprecated in wicket7 from both wicket8 and master
(or at least from master)
Can I?
On Tue, 13 Nov 2018 at 13:47, Martin Grigorov <mg...@apache.org> wrote:
> Hi Maxim,
>
> Anything that is deprecated and has "WIll be removed in Wicket 9" could be
> removed.
> But there are some classes which are deprecated in 9 but should be removed
> in 10.
>
> On Tue, Nov 13, 2018 at 6:09 AM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > Hello All,
> >
> > I noticed there are some classes deprecated in 8.2.0 which exists in
> 9.0.0
> > (For example org.apache.wicket.util.crypt.Base64)
> >
> > I would like to remove them
> >
> > Are there any objections?
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
--
WBR
Maxim aka solomax
Re: Remove deprecated classes in master
Posted by Martin Grigorov <mg...@apache.org>.
Hi Maxim,
Anything that is deprecated and has "WIll be removed in Wicket 9" could be
removed.
But there are some classes which are deprecated in 9 but should be removed
in 10.
On Tue, Nov 13, 2018 at 6:09 AM Maxim Solodovnik <so...@gmail.com>
wrote:
> Hello All,
>
> I noticed there are some classes deprecated in 8.2.0 which exists in 9.0.0
> (For example org.apache.wicket.util.crypt.Base64)
>
> I would like to remove them
>
> Are there any objections?
>
> --
> WBR
> Maxim aka solomax
>