You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/04 08:55:21 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4012: Add FlightSQL module docs and links to `arrow-flight` crates

tustvold commented on code in PR #4012:
URL: https://github.com/apache/arrow-rs/pull/4012#discussion_r1156939479


##########
arrow-flight/src/sql/mod.rs:
##########
@@ -15,6 +15,26 @@
 // specific language governing permissions and limitations
 // under the License.
 
+//! Support for execute SQL queries using [Apache Arrow] [Flight SQL].
+//!
+//! [Flight SQL] is built on top of Arrow Flight RPC framework, by
+//! defining specific message, encoded using the protobuf format, sent

Review Comment:
   ```suggestion
   //! defining specific messages, encoded using the protobuf format, sent
   ```



##########
arrow-flight/src/sql/mod.rs:
##########
@@ -15,6 +15,26 @@
 // specific language governing permissions and limitations
 // under the License.
 
+//! Support for execute SQL queries using [Apache Arrow] [Flight SQL].
+//!
+//! [Flight SQL] is built on top of Arrow Flight RPC framework, by

Review Comment:
   This might be easier to read if the link anchors were moved to the end



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org