You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/20 06:35:17 UTC
[GitHub] [flink] lirui-apache commented on a change in pull request #10894:
[FLINK-15592][hive] Add black list for Hive built-in functions
lirui-apache commented on a change in pull request #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#discussion_r368386963
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV120.java
##########
@@ -47,6 +51,14 @@
*/
public class HiveShimV120 extends HiveShimV111 {
+ // a set of functions that shouldn't be overridden by HiveModule
+ @VisibleForTesting
+ public static final Set<String> BUILT_IN_FUNC_BLACKLIST = Collections.unmodifiableSet(new HashSet<>(
Review comment:
I put it in the shim so that the filter is closer to the source. But I'm also fine to move it to HiveModule to make things clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services