You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/05/08 03:28:11 UTC

Review Request 21189: Added a test to ensure a non-strict registry is write-only.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21189/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-1319
    https://issues.apache.org/jira/browse/MESOS-1319


Repository: mesos-git


Description
-------

This test ensures that a non-strict registry is write-only by inducing a slave removal during recovery. We expect that the framework is *not* informed, and we expect that the slave can re-register successfully.


Diffs
-----

  src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42 

Diff: https://reviews.apache.org/r/21189/diff/


Testing
-------

./bin/mesos-tests.sh --gtest_filter="MasterTest.NonStrictRegistryWriteOnly" --gtest_repeat=200 --gtest_break_on_failure --verbose


Thanks,

Ben Mahler

Re: Review Request 21189: Added a test to ensure a non-strict registry is write-only.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21189/#review42518
-----------------------------------------------------------

Ship it!



src/tests/master_tests.cpp
<https://reviews.apache.org/r/21189/#comment76308>

    s/Re-start/Restart/


- Vinod Kone


On May 8, 2014, 1:28 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21189/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 1:28 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1319
>     https://issues.apache.org/jira/browse/MESOS-1319
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This test ensures that a non-strict registry is write-only by inducing a slave removal during recovery. We expect that the framework is *not* informed, and we expect that the slave can re-register successfully.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42 
> 
> Diff: https://reviews.apache.org/r/21189/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --gtest_filter="MasterTest.NonStrictRegistryWriteOnly" --gtest_repeat=200 --gtest_break_on_failure --verbose
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>