[GitHub] kwin commented on a change in pull request #1: SLING-7365 for unsupported java version fall back to Java 9

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #1: SLING-7365 for unsupported java version fall back to Java 9
URL: https://github.com/apache/sling-org-apache-sling-commons-compiler/pull/1#discussion_r161252363
 
 

 ##########
 File path: src/main/java/org/apache/sling/commons/compiler/impl/EclipseJavaCompiler.java
 ##########
 @@ -233,9 +233,12 @@ public CompilationResult compile(final CompilationUnit[] units,
     }
 
     private String adjustJavaVersion(String javaVersion) {
-
-        // ECJ 4.6.1 expects Java version 1.9, not 9
-        return "9".equals(javaVersion) ? "1.9" : javaVersion;
 
 Review comment:
   Exactly, the newer version of ECJ expects "9" not "1.9"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services