You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by becketqin <gi...@git.apache.org> on 2016/12/12 01:33:00 UTC
[GitHub] kafka pull request #2243: KAFKA-4497: LogCleaner appended the wrong offset t...
GitHub user becketqin opened a pull request:
https://github.com/apache/kafka/pull/2243
KAFKA-4497: LogCleaner appended the wrong offset to time index. Backport the fix to 0.10.1.
The code in trunk has been changed, so we need to provide a different fix for this problem in 0.10.1.
Some explanations. I was able to reproduce the initial issue with a unit test. I did not include the unit test here because the tests requires a lot of hard coded constants to precisely control the message size after compression, read buffer and which message is filtered out. In trunk I have added a unit test to `ByteBufferMessageSet.fliterInto()` which holds the current buggy logic. Given no one will be developing on 0.10.1 branch anymore except bug fixes, I think it is fine to leave the ugly unit test out of this patch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/becketqin/kafka KAFKA-4497-0.10.1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2243
----
commit 5b869e7ee4c6b554787330c386988b5447b127ca
Author: Jiangjie Qin <be...@gmail.com>
Date: 2016-12-12T01:32:05Z
KAFKA-4497: LogCleaner appended the wrong offset to time index. Backport the fix to 0.10.1.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #2243: KAFKA-4497: LogCleaner appended the wrong offset t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/2243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---