You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/02/03 22:58:04 UTC
[GitHub] [trafficserver] maskit opened a new pull request, #9381: Fix stack overflow on sending UDP packets
maskit opened a new pull request, #9381:
URL: https://github.com/apache/trafficserver/pull/9381
The check is simply wrong. It has to break out from the loop if `npackets` reaches the limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a diff in pull request #9381: Fix stack overflow on sending UDP packets
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on code in PR #9381:
URL: https://github.com/apache/trafficserver/pull/9381#discussion_r1099083195
##########
iocore/net/UnixUDPNet.cc:
##########
@@ -979,7 +979,7 @@ UDPQueue::SendPackets()
bytesThisPipe -= pktLen;
packets[npackets++] = p;
next_pkt:
- if (bytesThisPipe < 0 && npackets == N_MAX_PACKETS) {
+ if (bytesThisPipe < 0 || npackets == N_MAX_PACKETS) {
Review Comment:
>= seems safer, but it really shouldn't matter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #9381: Fix stack overflow on sending UDP packets
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #9381:
URL: https://github.com/apache/trafficserver/pull/9381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org