You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "jcompagner (via GitHub)" <gi...@apache.org> on 2025/06/30 13:23:17 UTC

[PR] jakarta-web relax the import package constraints [logging-log4j2]

jcompagner opened a new pull request, #3791:
URL: https://github.com/apache/logging-log4j2/pull/3791

   fixes: https://github.com/apache/logging-log4j2/issues/3787
   
   ## Checklist
   
   Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
   
   ### ✅ Required checks
   
   - [ X] **License**: I confirm that my changes are submitted under the [Apache License, Version 2.0](https://apache.org/licenses/LICENSE-2.0).
   - [ X] **Commit signatures**: All commits are signed and verifiable. (See [GitHub Docs on Commit Signature Verification](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)).
   - [ X] **Code formatting**: The code is formatted according to the project’s style guide.
     <details>
       <summary>How to check and fix formatting</summary>
   
       - To **check** formatting: `./mvnw spotless:check`
       - To **fix** formatting: `./mvnw spotless:apply`
   
       See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
     </details>
   - [ ] **Build & Test**: I verified that the project builds and all unit tests pass.
     <details>
       <summary>How to build the project</summary>
   
       Run: `./mvnw verify`
   
       See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
     </details>
   
   ### 🧪 Tests (select one)
   
   - [ ] I have added or updated tests to cover my changes.
   - [X ] No additional tests are needed for this change.
   
   ### 📝 Changelog (select one)
   
   - [ X] I added a changelog entry in `src/changelog/.2.x.x`. (See [Changelog Entry File Guide](https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file)).
   - [ ] This is a trivial change and does not require a changelog entry.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] jakarta-web relax the import package constraints [logging-log4j2]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #3791:
URL: https://github.com/apache/logging-log4j2/pull/3791#issuecomment-3020011986

   A snapshot should be ready as soon as the workflow finishes: https://github.com/apache/logging-log4j2/actions/runs/15978983571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] jakarta-web relax the import package constraints [logging-log4j2]

Posted by "jcompagner (via GitHub)" <gi...@apache.org>.
jcompagner commented on PR #3791:
URL: https://github.com/apache/logging-log4j2/pull/3791#issuecomment-3019694717

   hmm what is exactly the problem? should i add some spaces somewhere or remove some?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] jakarta-web relax the import package constraints [logging-log4j2]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #3791:
URL: https://github.com/apache/logging-log4j2/pull/3791#discussion_r2178140788


##########
src/changelog/.2.x.x/3787_jakarta-web_relax_the_import_package_constraints.xml:
##########
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<entry xmlns="https://logging.apache.org/xml/ns"
+       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+       xsi:schemaLocation="
+           https://logging.apache.org/xml/ns
+           https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"
+       type="changed">
+    <issue id="3787" link="https://github.com/apache/logging-log4j2/issues/3787"/>
+    <description format="asciidoc">
+     add a bnd tool property that makes sure that the supported jakarta version has a wider range then 5 to 6

Review Comment:
   @andrei-ivanov,
   
   Thanks, I'll keep it mind, while reviewing the changelog entries for the release.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] jakarta-web relax the import package constraints [logging-log4j2]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #3791:
URL: https://github.com/apache/logging-log4j2/pull/3791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] jakarta-web relax the import package constraints [logging-log4j2]

Posted by "andrei-ivanov (via GitHub)" <gi...@apache.org>.
andrei-ivanov commented on code in PR #3791:
URL: https://github.com/apache/logging-log4j2/pull/3791#discussion_r2176687031


##########
src/changelog/.2.x.x/3787_jakarta-web_relax_the_import_package_constraints.xml:
##########
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<entry xmlns="https://logging.apache.org/xml/ns"
+       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+       xsi:schemaLocation="
+           https://logging.apache.org/xml/ns
+           https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"
+       type="changed">
+    <issue id="3787" link="https://github.com/apache/logging-log4j2/issues/3787"/>
+    <description format="asciidoc">
+     add a bnd tool property that makes sure that the supported jakarta version has a wider range then 5 to 6

Review Comment:
   `than` instead of `then`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] jakarta-web relax the import package constraints [logging-log4j2]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3791:
URL: https://github.com/apache/logging-log4j2/pull/3791#issuecomment-3019680485

   
   
   <table>
       <tr>
           <th>Job</th>
           <th>Requested goals</th>
           <th>Build Tool Version</th>
           <th>Build Outcome</th>
           <th>Build Scan®</th>
       </tr>
       <tr>
           <td>build-macos-latest</td>
           <td>clean install</td>
           <td align='center'>3.9.8</td>
           <td align='center'>:x:</td>
           <td><a href="https://develocity.apache.org/s/24nej6ejed5to" rel="nofollow"><img src="https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle" alt="Build Scan PUBLISHED" /></a></td>
       </tr>
       <tr>
           <td>build-ubuntu-latest</td>
           <td>clean install</td>
           <td align='center'>3.9.8</td>
           <td align='center'>:x:</td>
           <td><a href="https://develocity.apache.org/s/usi2uflj5gfly" rel="nofollow"><img src="https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle" alt="Build Scan PUBLISHED" /></a></td>
       </tr>
       <tr>
           <td>build-windows-latest</td>
           <td>clean install</td>
           <td align='center'>3.9.8</td>
           <td align='center'>:x:</td>
           <td><a href="https://develocity.apache.org/s/rgsnpmtuca2g6" rel="nofollow"><img src="https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle" alt="Build Scan PUBLISHED" /></a></td>
       </tr>
   </table>
       
   
   ###### Generated by gradle/develocity-actions
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] jakarta-web relax the import package constraints [logging-log4j2]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #3791:
URL: https://github.com/apache/logging-log4j2/pull/3791#issuecomment-3019715214

   It is a formatting problem, run:
   
   ```bash
   ./mvnw spotless:apply
   ```
   
   to fix it and push the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org