[GitHub] tombell opened a new issue #489: Incorrect default min SDK version ternary in build.gradle

[GitBox <gi...@apache.org>]

tombell opened a new issue #489: Incorrect default min SDK version ternary in build.gradle
URL: https://github.com/apache/cordova-android/issues/489
 
 
   I've been trying to work out why the min SDK was always being set to `19` even when I updated it to `23` every where possible.
   
   I believe I've found an issue here https://github.com/apache/cordova-android/blob/master/bin/templates/project/app/build.gradle#L120 where it's setting the `cdvMinSdkVersion` to `null` when it's already `null`, else if it's not `null` it's setting it to the default min SDK version, meaning if you ever set a min SDK it will always change it to the default.
   
   I believe the correct line should read:
   
   ```
   ext.cdvMinSdkVersion = cdvMinSdkVersion == null ? defaultMinSdkVersion : cdvMinSdkVersion
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org