[GitHub] [tvm] comaniac commented on a change in pull request #7297: [FIX,AUTOTVM] Add flop counts to cublas

[GitBox <gi...@apache.org>]

comaniac commented on a change in pull request #7297:
URL: https://github.com/apache/tvm/pull/7297#discussion_r558723487



##########
File path: python/tvm/topi/cuda/dense.py
##########
@@ -44,6 +44,8 @@ def dense_cublas(cfg, data, weight, bias=None, out_dtype=None):
     matmul = cublas.matmul(data, weight, False, True)
     if isinstance(batch, int):
         cfg.add_flop(batch * in_dim * out_dim * 2)
+    else:
+        cfg.add_flop(batch.value * in_dim * out_dim * 2)

Review comment:
       Should have an assertion to make sure batch is a TVM container type.

##########
File path: python/tvm/autotvm/task/task.py
##########
@@ -580,6 +580,7 @@ def traverse(ops):
                 pass
             else:
                 raise FlopCalculationError(
+                    f"{op.name} is not supported by autotvm"

Review comment:
       ```suggestion
                       f"{op.name} is not supported by autotvm. "
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org