You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/07 02:22:24 UTC

[GitHub] [incubator-nuttx] Donny9 opened a new pull request, #5997: fs/mmap/msync: support msync and fix minor issue

Donny9 opened a new pull request, #5997:
URL: https://github.com/apache/incubator-nuttx/pull/5997

   ## Summary
   fs/mmap/msync: support msync and fix some minor issue
   
   Follow: https://man7.org/linux/man-pages/man2/msync.2.html
   
   ## Impact
   Support msync
   ## Testing
   Ci
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #5997: fs/mmap/msync: support msync and fix minor issue

Posted by GitBox <gi...@apache.org>.

yamt commented on PR #5997:
URL: https://github.com/apache/incubator-nuttx/pull/5997#issuecomment-1091257219

   * don't you need to distinguish MAP_SHARED/MAP_PRIVATE?
   * don't you need some reference counting on the file?
   * i guess mmap should not modify file offset. (not specific to this PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] Donny9 closed pull request #5997: fs/mmap/msync: support msync and fix minor issue

Posted by "Donny9 (via GitHub)" <gi...@apache.org>.

Donny9 closed pull request #5997: fs/mmap/msync: support msync and fix minor issue
URL: https://github.com/apache/nuttx/pull/5997


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #5997: fs/mmap/msync: support msync and fix minor issue

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on PR #5997:
URL: https://github.com/apache/nuttx/pull/5997#issuecomment-1377768067

   @Donny9 we can implement with the new mmap infrastructure which is simpler now: https://github.com/apache/nuttx/pull/8000 and https://github.com/apache/nuttx/pull/8026.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org