You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/07 07:13:39 UTC

[GitHub] [doris] zhengshiJ opened a new pull request, #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

zhengshiJ opened a new pull request, #12421:
URL: https://github.com/apache/doris/pull/12421

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   When the current non-correlated subquery is executed, an error will be reported that the corresponding column cannot be found.
   The reason is that the tupleID of the child obtained in visitPhysicalNestedLoopJoin is not consistent with the child.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] 924060929 commented on a diff in pull request #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #12421:
URL: https://github.com/apache/doris/pull/12421#discussion_r964502766


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalAssertNumRows.java:
##########
@@ -59,7 +60,8 @@ public AssertNumRowsElement getAssertNumRowsElement() {
 
     @Override
     public String toString() {
-        return "LogicalAssertNumRows (" + assertNumRowsElement + ")";
+        return Utils.toSqlString("LogicalAssertNumRows (",

Review Comment:
   ```suggestion
           return Utils.toSqlString("LogicalAssertNumRows",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morrySnow merged pull request #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #12421:
URL: https://github.com/apache/doris/pull/12421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] zhengshiJ commented on a diff in pull request #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

Posted by GitBox <gi...@apache.org>.
zhengshiJ commented on code in PR #12421:
URL: https://github.com/apache/doris/pull/12421#discussion_r965687294


##########
fe/fe-core/src/main/java/org/apache/doris/planner/CrossJoinNode.java:
##########
@@ -57,6 +58,26 @@ public CrossJoinNode(PlanNodeId id, PlanNode outer, PlanNode inner, TableRef inn
         nullableTupleIds.addAll(inner.getNullableTupleIds());
     }
 
+    /**
+     * .

Review Comment:
   done



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalAssertNumRows.java:
##########
@@ -59,7 +60,8 @@ public AssertNumRowsElement getAssertNumRowsElement() {
 
     @Override
     public String toString() {
-        return "LogicalAssertNumRows (" + assertNumRowsElement + ")";
+        return Utils.toSqlString("LogicalAssertNumRows (",

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] zhengshiJ commented on a diff in pull request #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

Posted by GitBox <gi...@apache.org>.
zhengshiJ commented on code in PR #12421:
URL: https://github.com/apache/doris/pull/12421#discussion_r965686990


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/AssertNumRowsElement.java:
##########
@@ -75,7 +75,7 @@ public AssertNumRowsElement withChildren(List<Expression> children) {
     public String toString() {
         return Utils.toSqlString("desiredNumOfRows: ",
                 Long.toString(desiredNumOfRows),
-                "assertion: " + assertion);
+                "assertion: ", assertion);

Review Comment:
   done



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalAssertNumRows.java:
##########
@@ -59,7 +60,8 @@ public AssertNumRowsElement getAssertNumRowsElement() {
 
     @Override
     public String toString() {
-        return "LogicalAssertNumRows (" + assertNumRowsElement + ")";
+        return Utils.toSqlString("LogicalAssertNumRows (",

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morrySnow commented on a diff in pull request #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #12421:
URL: https://github.com/apache/doris/pull/12421#discussion_r964499341


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalAssertNumRows.java:
##########
@@ -59,7 +60,8 @@ public AssertNumRowsElement getAssertNumRowsElement() {
 
     @Override
     public String toString() {
-        return "LogicalAssertNumRows (" + assertNumRowsElement + ")";
+        return Utils.toSqlString("LogicalAssertNumRows (",

Review Comment:
   ```suggestion
           return Utils.toSqlString("LogicalAssertNumRows",
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/AssertNumRowsElement.java:
##########
@@ -75,7 +75,7 @@ public AssertNumRowsElement withChildren(List<Expression> children) {
     public String toString() {
         return Utils.toSqlString("desiredNumOfRows: ",
                 Long.toString(desiredNumOfRows),
-                "assertion: " + assertion);
+                "assertion: ", assertion);

Review Comment:
   the first parameter is plan name, and followed by k-v pairs.



##########
fe/fe-core/src/main/java/org/apache/doris/planner/CrossJoinNode.java:
##########
@@ -57,6 +58,26 @@ public CrossJoinNode(PlanNodeId id, PlanNode outer, PlanNode inner, TableRef inn
         nullableTupleIds.addAll(inner.getNullableTupleIds());
     }
 
+    /**
+     * .

Review Comment:
   comment: used by Nereids only



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org