You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/06/11 20:19:55 UTC

svn commit: r1798401 - /jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java

Author: pmouawad
Date: Sun Jun 11 20:19:54 2017
New Revision: 1798401

URL: http://svn.apache.org/viewvc?rev=1798401&view=rev
Log:
Allow to use variables ( from User Defined Variables only ) in all listeners in slave mode
Renamve method to make it clearer

Bugzilla Id: 57962

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java?rev=1798401&r1=1798400&r2=1798401&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java Sun Jun 11 20:19:54 2017
@@ -47,9 +47,8 @@ public final class JMeterContextService
     //@GuardedGy("this")
     private static int totalThreads = 0;
     
-    //@GuardedGy("this")
     private static JMeterVariables variables = null;
-    
+
 
     /**
      * Private constructor to prevent instantiation.
@@ -168,10 +167,11 @@ public final class JMeterContextService
     }
     
     /**
-     * Get all variables accessible for JMeter client in a distributed test (exclusively test plan and user defined variables )
-     * @return variables available for JMeter client 
+     * Get all variables accessible for JMeter client in a distributed test
+     * (only test plan and user defined variables)
+     * @return {@link JMeterVariables} available for JMeter client 
      */
-    public static JMeterVariables getClientVariable() {
+    public static JMeterVariables getClientVariables() {
         return variables;
     }
     
@@ -179,9 +179,9 @@ public final class JMeterContextService
      * Set variables for JMeter client in a distributed test
      * @param var {@link JMeterVariables}
      */
-    public static void setClientVariable(JMeterVariables var) {
+    public static void setClientVariables(JMeterVariables var) {
         variables = var;
-    }    
+    }
 
     public static class ThreadCounts {
         
@@ -197,5 +197,4 @@ public final class JMeterContextService
             finishedThreads = finished;
         }
     }
-
 }



Re: svn commit: r1798401 - /jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java

Posted by sebb <se...@gmail.com>.
On 11 June 2017 at 21:19,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Sun Jun 11 20:19:54 2017
> New Revision: 1798401
>
> URL: http://svn.apache.org/viewvc?rev=1798401&view=rev
> Log:
> Allow to use variables ( from User Defined Variables only ) in all listeners in slave mode
> Renamve method to make it clearer
>
> Bugzilla Id: 57962
>
> Modified:
>     jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java?rev=1798401&r1=1798400&r2=1798401&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java Sun Jun 11 20:19:54 2017
> @@ -47,9 +47,8 @@ public final class JMeterContextService
>      //@GuardedGy("this")

=> GuardedBy

>      private static int totalThreads = 0;
>
> -    //@GuardedGy("this")

Why was this comment deleted?

>      private static JMeterVariables variables = null;
> -
> +
>
>      /**
>       * Private constructor to prevent instantiation.
> @@ -168,10 +167,11 @@ public final class JMeterContextService
>      }
>
>      /**
> -     * Get all variables accessible for JMeter client in a distributed test (exclusively test plan and user defined variables )
> -     * @return variables available for JMeter client
> +     * Get all variables accessible for JMeter client in a distributed test
> +     * (only test plan and user defined variables)
> +     * @return {@link JMeterVariables} available for JMeter client
>       */
> -    public static JMeterVariables getClientVariable() {
> +    public static JMeterVariables getClientVariables() {
>          return variables;
>      }
>
> @@ -179,9 +179,9 @@ public final class JMeterContextService
>       * Set variables for JMeter client in a distributed test
>       * @param var {@link JMeterVariables}
>       */
> -    public static void setClientVariable(JMeterVariables var) {
> +    public static void setClientVariables(JMeterVariables var) {
>          variables = var;
> -    }
> +    }
>
>      public static class ThreadCounts {
>
> @@ -197,5 +197,4 @@ public final class JMeterContextService
>              finishedThreads = finished;
>          }
>      }
> -
>  }
>
>