You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by LiShuMing <gi...@git.apache.org> on 2017/05/27 15:06:28 UTC
[GitHub] spark pull request #18130: [Web UI] Remove no need loop in JobProgressListen...
GitHub user LiShuMing opened a pull request:
https://github.com/apache/spark/pull/18130
[Web UI] Remove no need loop in JobProgressListener
## What changes were proposed in this pull request?
I found it's unnecessary to use the same loop twice, so changed them into one. It's a little change...
## How was this patch tested?
`./build/mvn -P... -Dtest=none -DwildcardSuites=org.apache.spark.ui.jobs.JobProgressListenerSuite test`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/LiShuMing/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18130
----
commit 6e18316254081603ffb8f387de0a35c18155c0bd
Author: lishuming <al...@126.com>
Date: 2017-05-27T15:01:36Z
remove no need loop in JobProgressListener
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18130: [Web UI] Remove no need loop in JobProgressListener
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18130
There's a [JIRA](https://issues.apache.org/jira/browse/SPARK-20650) planning to remove this `JobProgressListener`, so I'd suggest to not change this deprecated code unnecessarily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18130: [Web UI] Remove no need loop in JobProgressListener
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18130
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18130: [Web UI] Remove no need loop in JobProgressListen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18130: [Web UI] Remove no need loop in JobProgressListen...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18130#discussion_r118824449
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -202,12 +202,13 @@ class JobProgressListener(conf: SparkConf) extends SparkListener with Logging {
}
jobIdToData(jobStart.jobId) = jobData
activeJobs(jobStart.jobId) = jobData
- for (stageId <- jobStart.stageIds) {
- stageIdToActiveJobIds.getOrElseUpdate(stageId, new HashSet[StageId]).add(jobStart.jobId)
- }
+
// If there's no information for a stage, store the StageInfo received from the scheduler
// so that we can display stage descriptions for pending stages:
for (stageInfo <- jobStart.stageInfos) {
+ stageIdToActiveJobIds.getOrElseUpdate(stageInfo.stageId,
--- End diff --
It's not immediately clear to me they're equivalent. They'd have to contain the same set of stage IDs. Is it worth it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18130: [Web UI] Remove no need loop in JobProgressListener
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18130
It seems to me that the older versions of `SparkListenerJobStart` don't store `StageInfos`, so it may be dangerous to apply this code change. @cloud-fan Should we close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org