You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/29 10:00:59 UTC
[GitHub] [maven-surefire] sman-81 opened a new pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
sman-81 opened a new pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453
This PR addresses the issue in [SUREFIRE-1994] to upgrade/configure `javacc-maven-plugin`.
✅ Each commit in the pull request should have a meaningful subject line and body.
✅ Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`
✅ Run `mvn clean install` to make sure basic checks pass.
(I use `mvn clean verify` usually which is the same but does not put artifacts into the local repo.)
✅ I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795035960
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+ <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+ <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
+ <outputDirectory>${generated.sources.dir}</outputDirectory>
Review comment:
why change default value .... `${project.build.directory}/generated-sources/javacc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r799345686
##########
File path: README.md
##########
@@ -63,7 +63,23 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
```
mvn install site site:stage -P reporting,run-its
```
-
+
+* To set up the project in **Eclipse IDE** , please follow these steps:
+
+ * Maven-build (without tests) the `surefire-shared-utils` module with profile `ide-development` and install it into the local maven repository
+ ```
+ cd surefire-shared-utils
+ mvn clean install -Pide-development -DskipTests
+ ```
+ * Maven-build the `surefire-grouper` module to generate sources into `target/generated-sources/javacc`
+ ```
+ cd surefire-grouper
+ mvn clean verify
Review comment:
Perhaps rephrase the sentense to:
Build the module `surefire-grouper` using the Maven command `mvn compile -f surefire-grouper/pom.xml` in order to generate a source code in `target/generated-sources/javacc and compile it`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029054216
@sman-81
You used `git rebase` with `forced push` or you have used `git merge`?
It looks like you use merge and that's the reason why we can see commits of master as yours.
It would be maybe easier for you cherry pick only your commit and use it in a fresh PR. I am afraid this has conflicts with master since the GH does not let be merge this PR - the button is shaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029116823
@sman-81
yes, feel free to go for it. Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r799340980
##########
File path: README.md
##########
@@ -63,7 +63,23 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
```
mvn install site site:stage -P reporting,run-its
```
-
+
+* To set up the project in **Eclipse IDE** , please follow these steps:
+
+ * Maven-build (without tests) the `surefire-shared-utils` module with profile `ide-development` and install it into the local maven repository
+ ```
+ cd surefire-shared-utils
+ mvn clean install -Pide-development -DskipTests
Review comment:
The module does not have tests. The more simple command line is `mvn install -P ide-development -f surefire-shared-utils/pom.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r799340980
##########
File path: README.md
##########
@@ -63,7 +63,23 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
```
mvn install site site:stage -P reporting,run-its
```
-
+
+* To set up the project in **Eclipse IDE** , please follow these steps:
+
+ * Maven-build (without tests) the `surefire-shared-utils` module with profile `ide-development` and install it into the local maven repository
+ ```
+ cd surefire-shared-utils
+ mvn clean install -Pide-development -DskipTests
Review comment:
The module does not have tests. More simple command line is `mvn install -P ide-development -f surefire-shared-utils/pom.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1025136294
This works as well and it is binary compliant with the old plugin.
```
<plugin>
<groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
<version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
<goal>jjdoc</goal>
</goals>
</execution>
</executions>
<dependencies>
<dependency>
<groupId>net.java.dev.javacc</groupId>
<artifactId>javacc</artifactId>
<version>7.0.10</version>
</dependency>
</dependencies>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795085714
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+ <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+ <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
+ <outputDirectory>${generated.sources.dir}</outputDirectory>
Review comment:
@sman-81
Don;t modify default settings unless it is absolutely necessary.
The old plugin is compliant with IDEs, the default layout, where generates sources appear in `target/generated-sources/javacc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795086694
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+ <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+ <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
Review comment:
Nowadays the IDEs can be configured to run the compilation and lokkup `target/generated-sources` which is default path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 edited a comment on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
sman-81 edited a comment on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029081571
> @sman-81 You used `git rebase` with `forced push` or you have used `git merge`?
1. I fetched upstream at github on my branch
2. then pulled
3. squashed using `git rebase -i HEAD~15`
4. followed by `push --force`
No 1 and 2 weren't so clever I can see now.
I'll make a new pull request, ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r799345686
##########
File path: README.md
##########
@@ -63,7 +63,23 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
```
mvn install site site:stage -P reporting,run-its
```
-
+
+* To set up the project in **Eclipse IDE** , please follow these steps:
+
+ * Maven-build (without tests) the `surefire-shared-utils` module with profile `ide-development` and install it into the local maven repository
+ ```
+ cd surefire-shared-utils
+ mvn clean install -Pide-development -DskipTests
+ ```
+ * Maven-build the `surefire-grouper` module to generate sources into `target/generated-sources/javacc`
+ ```
+ cd surefire-grouper
+ mvn clean verify
Review comment:
Perhaps rephrase the sentense to:
Build the module `surefire-grouper` using the Maven command `mvn compile -f surefire-grouper/pom.xml` in order to generate sources in `target/generated-sources/javacc and compile them`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029054216
@sman-81
You used `git rebase` or you have used `git merge`?
It looks like you use merge and that's the reason why we can see commits of master as yours.
It would be maybe easier for you cherry pick only your commit and use it in a fresh PR. I am afraid this has conflicts with master since the GH does not let be merge this PR - the button is shaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029054216
@sman-81
You used `git rebase` or you have used `git merge`?
It looks like you use merge and that's the reason why we can see commits of master as yours.
It would be maybe easier for you cherry pick only your commit and use it in a fresh PR. I am afraid this has conflicts with master it the GH does not let be merge this PR - the button is shaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r799345686
##########
File path: README.md
##########
@@ -63,7 +63,23 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
```
mvn install site site:stage -P reporting,run-its
```
-
+
+* To set up the project in **Eclipse IDE** , please follow these steps:
+
+ * Maven-build (without tests) the `surefire-shared-utils` module with profile `ide-development` and install it into the local maven repository
+ ```
+ cd surefire-shared-utils
+ mvn clean install -Pide-development -DskipTests
+ ```
+ * Maven-build the `surefire-grouper` module to generate sources into `target/generated-sources/javacc`
+ ```
+ cd surefire-grouper
+ mvn clean verify
Review comment:
Perhaps rephrase the sentense to:
Build the module `surefire-grouper` using the Maven command `mvn compile -f surefire-grouper/pom.xml` in order to generate a source code in `target/generated-sources/javacc` and compile it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029808196
Hello @Tibor17
now the pr is correctly rebased and squashed. Please take a look :)
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r799340980
##########
File path: README.md
##########
@@ -63,7 +63,23 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
```
mvn install site site:stage -P reporting,run-its
```
-
+
+* To set up the project in **Eclipse IDE** , please follow these steps:
+
+ * Maven-build (without tests) the `surefire-shared-utils` module with profile `ide-development` and install it into the local maven repository
+ ```
+ cd surefire-shared-utils
+ mvn clean install -Pide-development -DskipTests
Review comment:
The module does not have tests. The more simple command is `mvn install -P ide-development -f surefire-shared-utils/pom.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029961967
> @sman-81 @slawekjaranowski LGTM. No objections?
well ..., I don't :)
have a good week-end!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
sman-81 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r799404715
##########
File path: README.md
##########
@@ -63,7 +63,23 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
```
mvn install site site:stage -P reporting,run-its
```
-
+
+* To set up the project in **Eclipse IDE** , please follow these steps:
+
+ * Maven-build (without tests) the `surefire-shared-utils` module with profile `ide-development` and install it into the local maven repository
+ ```
+ cd surefire-shared-utils
+ mvn clean install -Pide-development -DskipTests
+ ```
+ * Maven-build the `surefire-grouper` module to generate sources into `target/generated-sources/javacc`
+ ```
+ cd surefire-grouper
+ mvn clean verify
Review comment:
@Tibor17
> Perhaps rephrase the sentense ...
Done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1030589084
@Tibor17 Thank you, too. I like your attention to detail. It was good working together!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r799345686
##########
File path: README.md
##########
@@ -63,7 +63,23 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
```
mvn install site site:stage -P reporting,run-its
```
-
+
+* To set up the project in **Eclipse IDE** , please follow these steps:
+
+ * Maven-build (without tests) the `surefire-shared-utils` module with profile `ide-development` and install it into the local maven repository
+ ```
+ cd surefire-shared-utils
+ mvn clean install -Pide-development -DskipTests
+ ```
+ * Maven-build the `surefire-grouper` module to generate sources into `target/generated-sources/javacc`
+ ```
+ cd surefire-grouper
+ mvn clean verify
Review comment:
Perhaps rephrase the sentense to:
Build the module `surefire-grouper` using the Maven command `mvn compile -f surefire-grouper/pom.xml` in order to generate and compile sources into `target/generated-sources/javacc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r798627006
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,12 +32,16 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
Review comment:
You can inline this value, that's not a problem for us, we will understand the point anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
sman-81 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795038490
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+ <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+ <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
+ <outputDirectory>${generated.sources.dir}</outputDirectory>
Review comment:
It's a bad default imho. People don't expect source folders to exist in the build directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1025129208
I have checked it out and the following plugin fails with an error
`Execution javacc of goal org.javacc.plugin:javacc-maven-plugin:3.0.3:javacc failed: A required class was missing while executing org.javacc.plugin:javacc-maven-plugin:3.0.3:javacc: org/javacc/parser/Main`
```
<groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
<version>3.0.3</version>
```
I have used another plugin which release was made 20 days ago and it is stable
```
<groupId>com.helger.maven</groupId>
<artifactId>ph-javacc-maven-plugin</artifactId>
<version>4.1.4</version>
```
The directory structure is the same and I did not provide any additional configuration (only used groupId:artifactId:version).
Used two goals for JavaDoc as well:
```
<goal>javacc</goal>
<goal>jjdoc</goal>
```
and compiled the project `mvn clean install -DskipTests` successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1028635203
@sman-81
It looks fine so far but I would like to review only one commit. Can you pls squash both commits? Thx
BTW, how is your Eclipse settings now? Did my links help in Jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
sman-81 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795038397
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+ <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+ <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
Review comment:
I like things to be obvious and explicit. Devs not familiar with the workings of this plugin will be able to understand better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795085938
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+ <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+ <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
Review comment:
@sman-81
Don;t modify default settings unless it is absolutely necessary.
The old plugin is compliant with IDEs, the default layout, where generates sources appear in `target/generated-sources/javacc`.
The `src/main` files are a subject to git commit them. So I disagree to touch this folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 merged pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 merged pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r799345686
##########
File path: README.md
##########
@@ -63,7 +63,23 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
```
mvn install site site:stage -P reporting,run-its
```
-
+
+* To set up the project in **Eclipse IDE** , please follow these steps:
+
+ * Maven-build (without tests) the `surefire-shared-utils` module with profile `ide-development` and install it into the local maven repository
+ ```
+ cd surefire-shared-utils
+ mvn clean install -Pide-development -DskipTests
+ ```
+ * Maven-build the `surefire-grouper` module to generate sources into `target/generated-sources/javacc`
+ ```
+ cd surefire-grouper
+ mvn clean verify
Review comment:
Perhaps rephrase the sentense to:
Build the module `surefire-grouper` using the Maven command `mvn compile -f surefire-grouper/pom.xml` in order to generate a source code in `target/generated-sources/javacc and compile them`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029039128
@Tibor17
I've merged upstream modifications, git-squashed the two commits of this ticket, and renamed the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029081571
> @sman-81 You used `git rebase` with `forced push` or you have used `git merge`?
I fetched upstream at github on my branch
then pulled
squashed using `git rebase -i HEAD~15`
followed by `push --force`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
sman-81 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r798652869
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,12 +32,16 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795036113
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+ <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+ <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
Review comment:
default value is `${basedir}/src/main/javacc`, so looks the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1025129208
I have checked it out and the following plugin fails on error
`Execution javacc of goal org.javacc.plugin:javacc-maven-plugin:3.0.3:javacc failed: A required class was missing while executing org.javacc.plugin:javacc-maven-plugin:3.0.3:javacc: org/javacc/parser/Main`
```
<groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
<version>3.0.3</version>
```
I have used another plugin which release was made 20 days ago and it is stable
```
<groupId>com.helger.maven</groupId>
<artifactId>ph-javacc-maven-plugin</artifactId>
<version>4.1.4</version>
```
The directory structure is the same and I did not provide any additional configuration (only used groupId:artifactId:version).
Used two goals for JavaDoc as well:
```
<goal>javacc</goal>
<goal>jjdoc</goal>
```
and compiled the project `mvn clean install -DskipTests` successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795086694
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+ <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+ <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
Review comment:
Nowadays the IDEs can be configured to run the compilation and lookup `target/generated-sources` which is default path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
sman-81 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795094164
##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
<name>Maven Surefire Test-Grouping Support</name>
<description>Maven Surefire Test-Grouping Support</description>
+ <properties>
+ <javacc.version>7.0.10</javacc.version>
+ <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+ </properties>
+
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
+ <groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.0.3</version>
<executions>
<execution>
<id>javacc</id>
<goals>
<goal>javacc</goal>
</goals>
+ <configuration>
+ <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>
Review comment:
> The `src/main` files are a subject to git commit them. So I disagree to touch this folder.
@Tibor17
Did you notice `.gitignore` was updated to prevent this?
Take a look at my comment in the Jira-Ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1025129208
I have checked it out and the following plugin fails on error
`Execution javacc of goal org.javacc.plugin:javacc-maven-plugin:3.0.3:javacc failed: A required class was missing while executing org.javacc.plugin:javacc-maven-plugin:3.0.3:javacc: org/javacc/parser/Main`
```
<groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
<version>3.0.3</version>
```
I have used another plugin which release was made 20 days ago and it is stable
```
<groupId>com.helger.maven</groupId>
<artifactId>ph-javacc-maven-plugin</artifactId>
<version>4.1.4</version>
```
The directory structure is the same and I did not provide any additional configuration (only used groupId:artifactId:version).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] sman-81 commented on pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1025129600
@Tibor17 for `org.javacc.plugin:javacc-maven-plugin` you need to configure `javacc` as a dependency. It's in my pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1029948389
@sman-81
@slawekjaranowski
LGTM. No objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #453: [SUREFIRE-1994] Upgrade javacc-maven-plugin, add setup instructions for Eclipse
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#issuecomment-1030408953
Thx for contributing and the PR! Let's keep tehm coming more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org