You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2022/11/03 18:55:31 UTC

[GitHub] [opennlp] rzo1 opened a new pull request, #433: OPENNLP-1391: Publish snapshot builds

rzo1 opened a new pull request, #433:
URL: https://github.com/apache/opennlp/pull/433

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   
   # Additional Notes
   
   This PR solves https://issues.apache.org/jira/browse/OPENNLP-1391
   
   However, it requires an INFRA ticket (created by a **PMC** member) to setup **secrets.NEXUS_USER** and
   **secrets.NEXUS_PW** for this project, see [1] or [2] for reference.
   
   The action isn't tested on the OPENNLP repository (no permissions obviously), but should work fine, if the related **secrets** are set by INFRA.
   
   
   [1] https://www.mail-archive.com/builds@apache.org/msg08188.html
   [2] https://github.com/search?q=org%3Aapache+NEXUS_USER&type=code
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] rzo1 commented on pull request #433: OPENNLP-1391: Publish snapshot builds

Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #433:
URL: https://github.com/apache/opennlp/pull/433#issuecomment-1325335376

   Yes :-) - thanks for creating it. If the INFRA ticket is closed, we can proceed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] jzonthemtn commented on pull request #433: OPENNLP-1391: Publish snapshot builds

Posted by GitBox <gi...@apache.org>.
jzonthemtn commented on PR #433:
URL: https://github.com/apache/opennlp/pull/433#issuecomment-1327938106

   I can confirm that the snapshots were uploaded to the snapshot repository: https://repository.apache.org/content/repositories/snapshots/org/apache/opennlp/
   
   Thanks @rzo1! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] jzonthemtn commented on pull request #433: OPENNLP-1391: Publish snapshot builds

Posted by GitBox <gi...@apache.org>.
jzonthemtn commented on PR #433:
URL: https://github.com/apache/opennlp/pull/433#issuecomment-1325322117

   Thanks @rzo1! This will be a big help.
   
   I will make that INFRA ticket to get those secrets created. I guess we should wait to merge this until those secrets exist?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] jzonthemtn merged pull request #433: OPENNLP-1391: Publish snapshot builds

Posted by GitBox <gi...@apache.org>.
jzonthemtn merged PR #433:
URL: https://github.com/apache/opennlp/pull/433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] jzonthemtn commented on pull request #433: OPENNLP-1391: Publish snapshot builds

Posted by GitBox <gi...@apache.org>.
jzonthemtn commented on PR #433:
URL: https://github.com/apache/opennlp/pull/433#issuecomment-1327936622

   INFRA has created the secrets. I'm going to merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org