[GitHub] metron pull request #1198: METRON-1780: Fix broken website images

[justinleet <gi...@git.apache.org>]

GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/1198

    METRON-1780: Fix broken website images

    ## Contributor Comments
    Noticed that a couple images have been broken through at least the 0.5.0 release, but didn't want to hold up the 0.6.0 release.
    
    This makes the manual changes necessary to get it working again in `generate-md.sh`.
    
    Please check out https://cwiki.apache.org/confluence/display/METRON/Website+PR+Merge for instructions on how to spin it up.
    
    Just click through all the pages. No errors should occur on the command line related to a file not found.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron site_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1198
    
----
commit f240a266b9ca0fc3d50ef0f72e445a067b651787
Author: Justin Leet <ju...@...>
Date:   2018-09-13T20:49:59Z

    Fixing site images

----


---

[GitHub] metron pull request #1198: METRON-1780: Fix broken website images

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/metron/pull/1198


---

[GitHub] metron issue #1198: METRON-1780: Fix broken website images

[mmiklavc <gi...@git.apache.org>]

Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/1198
  
    +1, thanks @justinleet.
    
    Verified this by clicking through all links on the main website as well as the site-book. It wasn't immediately clear to me from the PR description, but looking at the diff changes this appears to address issues specific to the site-book, in particular under the use-cases section.


---