You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2023/06/20 09:40:12 UTC
[GitHub] [iceberg] nastra opened a new pull request, #7867: Core: Add create(..) method to UpdateTableRequest
nastra opened a new pull request, #7867:
URL: https://github.com/apache/iceberg/pull/7867
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #7867: Core: Add create(..) method to UpdateTableRequest
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7867:
URL: https://github.com/apache/iceberg/pull/7867#discussion_r1241078305
##########
core/src/main/java/org/apache/iceberg/catalog/TableCommit.java:
##########
@@ -26,6 +26,12 @@
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.immutables.value.Value;
+/**
+ * This represents a commit to be applied for a single table with {@link UpdateRequirement}s to be
+ * validated and {@link MetadataUpdate}s that have been applied. The {@link UpdateRequirement}s and
+ * {@link MetadataUpdate}s can be derived from table's base and updated {@link TableMetadata} when
+ * using {@link TableCommit#create(TableIdentifier, TableMetadata, TableMetadata)}.
+ */
Review Comment:
I've added the Javadoc to make this clearer when using the `create` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #7867: Core: Add create(..) method to UpdateTableRequest
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #7867:
URL: https://github.com/apache/iceberg/pull/7867#discussion_r1240045006
##########
core/src/main/java/org/apache/iceberg/catalog/TableCommit.java:
##########
@@ -26,6 +26,12 @@
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.immutables.value.Value;
+/**
+ * This represents a commit to be applied for a single table with {@link UpdateRequirement}s to be
+ * validated and {@link MetadataUpdate}s that have been applied. The {@link UpdateRequirement}s and
+ * {@link MetadataUpdate}s can be derived from table's base and updated {@link TableMetadata} when
+ * using {@link TableCommit#create(TableIdentifier, TableMetadata, TableMetadata)}.
+ */
Review Comment:
Can you also add Javadoc for the `create` method? It has requirements for the `TableMetadata` objects that should be noted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra merged pull request #7867: Core: Add create(..) method to UpdateTableRequest
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #7867:
URL: https://github.com/apache/iceberg/pull/7867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #7867: Core: Add create(..) method to UpdateTableRequest
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #7867:
URL: https://github.com/apache/iceberg/pull/7867#issuecomment-1606835076
Thanks for reviewing @rdblue, I've added the Javadoc to make things clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org