You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/17 21:33:17 UTC
[GitHub] anirudh2290 commented on a change in pull request #11780: fix flaky
test test_operator_gpu.test_countsketch
anirudh2290 commented on a change in pull request #11780: fix flaky test test_operator_gpu.test_countsketch
URL: https://github.com/apache/incubator-mxnet/pull/11780#discussion_r203185893
##########
File path: src/operator/contrib/count_sketch.cu
##########
@@ -129,8 +129,8 @@ inline void CountSketchForward(const Tensor<gpu, 2, DType> &out,
nthreads, out_ptr+bstart*out_dim, h_ptr,
s_ptr, in_ptr+bstart*in_dim, batchlen,
in_dim, out_dim);
- MSHADOW_CUDA_POST_KERNEL_CHECK(sketch_forward_kernel);
- // cudaThreadSynchronize();
+ cudaError_t err = cudaDeviceSynchronize();
+ CHECK_EQ(err, cudaSuccess) << "Error occured! CUDA: " << cudaGetErrorString(err);
Review comment:
why do we need to replace this? is it to improve the error message ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services