You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/11 04:37:31 UTC
[GitHub] [flink] wuchong commented on a change in pull request #9029:
[FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table
source with streaming table source
wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source
URL: https://github.com/apache/flink/pull/9029#discussion_r302354841
##########
File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
##########
@@ -74,12 +118,56 @@ public static Builder builder() {
return new Builder();
}
+ private JDBCInputFormat getInputFormat() {
+ JDBCInputFormat.JDBCInputFormatBuilder builder = JDBCInputFormat.buildJDBCInputFormat()
+ .setDrivername(options.getDriverName())
+ .setDBUrl(options.getDbURL())
+ .setUsername(options.getUsername())
+ .setPassword(options.getPassword())
+ .setRowTypeInfo(new RowTypeInfo(schema.getFieldTypes(), schema.getFieldNames()));
Review comment:
The field types and field names should be projected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services