You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/11/13 07:11:40 UTC

[GitHub] spark pull request #22989: [SPARK-25986][Build] Add rules to ban throw Error...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22989#discussion_r232917777
  
    --- Diff: dev/checkstyle-suppressions.xml ---
    @@ -46,4 +46,12 @@
                   files="sql/catalyst/src/main/java/org/apache/spark/sql/streaming/GroupStateTimeout.java"/>
         <suppress checks="MethodName"
                   files="sql/core/src/main/java/org/apache/spark/sql/streaming/Trigger.java"/>
    +    <suppress checks="RegexpSingleline"
    --- End diff --
    
    I think this might suppress many checks? is it difficult to suppress with comments in these files?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org