You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2001/02/23 04:10:42 UTC

Re: CVS update: subversion/subversion/libsvn_fs node-rev.c

The most portable form is:

#define APR_WANT_MEMFUNC
#include "apr_want.h"

It'll go and find the right header for you. Other options are STRFUNC,
STDIO, IOVEC, SIGNAL, and BYTEFUNC (see the header).

Cheers,
-g

On Thu, Feb 22, 2001 at 05:49:22PM -0000, kfogel@tigris.org wrote:
>   User: kfogel  
>   Date: 01/02/22 09:49:22
> 
>   Modified:    subversion/libsvn_fs node-rev.c
>   Log:
>   #include <string.h>, for memset.
>   
>   Revision  Changes    Path
>   1.7       +1 -0      subversion/subversion/libsvn_fs/node-rev.c
>   
>   Index: node-rev.c
>   ===================================================================
>   RCS file: /cvs/subversion/subversion/libsvn_fs/node-rev.c,v
>   retrieving revision 1.6
>   retrieving revision 1.7
>   diff -u -r1.6 -r1.7
>   --- node-rev.c	2001/02/21 16:52:02	1.6
>   +++ node-rev.c	2001/02/22 17:49:22	1.7
>   @@ -11,6 +11,7 @@
>     * ====================================================================
>     */
>    
>   +#include <string.h>
>    #include <db.h>
>    
>    #include "svn_fs.h"
>   
>   
>   

-- 
Greg Stein, http://www.lyra.org/

Re: CVS update: subversion/subversion/libsvn_fs node-rev.c

Posted by Ben Collins-Sussman <su...@newton.ch.collab.net>.
Greg Stein <gs...@lyra.org> writes:

> btw... Happy Birthday, old man :-)
> 

Yes indeed.  Today is Karl's 30th birthday, a Big One.  

While I know that he loves the digeridoo given to him by Fitz and
Lefty, the best gift this community can give him is a WORKING
FILESYSTEM.  'Twould melt his heart.  :)

Re: CVS update: subversion/subversion/libsvn_fs node-rev.c

Posted by Greg Stein <gs...@lyra.org>.
On Fri, Feb 23, 2001 at 11:49:09AM -0600, Karl Fogel wrote:
> Greg Stein <gs...@lyra.org> writes:
> > The most portable form is:
> > 
> > #define APR_WANT_MEMFUNC
> > #include "apr_want.h"
> > 
> > It'll go and find the right header for you. Other options are STRFUNC,
> > STDIO, IOVEC, SIGNAL, and BYTEFUNC (see the header).
> 
> Urnh?
> 
> Having memset in <string.h> is ANSI (which is all we ever claim to
> be).  Do we actually experience portability problems anyway from this?

I believe old SunOS systems have an issue with it, yes.

btw... Happy Birthday, old man :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: CVS update: subversion/subversion/libsvn_fs node-rev.c

Posted by Karl Fogel <kf...@galois.collab.net>.
Greg Stein <gs...@lyra.org> writes:
> The most portable form is:
> 
> #define APR_WANT_MEMFUNC
> #include "apr_want.h"
> 
> It'll go and find the right header for you. Other options are STRFUNC,
> STDIO, IOVEC, SIGNAL, and BYTEFUNC (see the header).

Urnh?

Having memset in <string.h> is ANSI (which is all we ever claim to
be).  Do we actually experience portability problems anyway from this?

-K



> Cheers,
> -g
> 
> On Thu, Feb 22, 2001 at 05:49:22PM -0000, kfogel@tigris.org wrote:
> >   User: kfogel  
> >   Date: 01/02/22 09:49:22
> > 
> >   Modified:    subversion/libsvn_fs node-rev.c
> >   Log:
> >   #include <string.h>, for memset.
> >   
> >   Revision  Changes    Path
> >   1.7       +1 -0      subversion/subversion/libsvn_fs/node-rev.c
> >   
> >   Index: node-rev.c
> >   ===================================================================
> >   RCS file: /cvs/subversion/subversion/libsvn_fs/node-rev.c,v
> >   retrieving revision 1.6
> >   retrieving revision 1.7
> >   diff -u -r1.6 -r1.7
> >   --- node-rev.c	2001/02/21 16:52:02	1.6
> >   +++ node-rev.c	2001/02/22 17:49:22	1.7
> >   @@ -11,6 +11,7 @@
> >     * ====================================================================
> >     */
> >    
> >   +#include <string.h>
> >    #include <db.h>
> >    
> >    #include "svn_fs.h"
> >   
> >   
> >   
> 
> -- 
> Greg Stein, http://www.lyra.org/