You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sirona.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2016/04/27 16:02:12 UTC

[jira] [Commented] (SIRONA-62) Counter#reset() must not set concurrency to zero

    [ https://issues.apache.org/jira/browse/SIRONA-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260199#comment-15260199 ] 

Hudson commented on SIRONA-62:
------------------------------

SUCCESS: Integrated in sirona-1.7 #127 (See [https://builds.apache.org/job/sirona-1.7/127/])
SIRONA-62 don't reset concurrent counter, but only maxConcurrent

Otherwise we will end up with negative counters when a reset() is done when requests are still running (struberg: rev 1741264)
* api/src/main/java/org/apache/sirona/counters/DefaultCounter.java


> Counter#reset() must not set concurrency to zero
> ------------------------------------------------
>
>                 Key: SIRONA-62
>                 URL: https://issues.apache.org/jira/browse/SIRONA-62
>             Project: Sirona
>          Issue Type: Bug
>    Affects Versions: 0.3-incubating
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>
> DefaultCounter#reset() currently sets the current concurrency to 0. This is wrong! There might be an action in progress, and if they stop the watch in finally, then this will lead to negative numbers obviously.
> We _should_ instead reset the max_concurrency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)