You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Praveen Agrawal (JIRA)" <ji...@apache.org> on 2014/03/11 07:17:42 UTC

[jira] [Created] (OFBIZ-5572) recreateOrderAdjustments service doesn't calculate the New promotion adjustment amount correctly

Praveen Agrawal created OFBIZ-5572:
--------------------------------------

             Summary: recreateOrderAdjustments service doesn't calculate the New promotion adjustment amount correctly
                 Key: OFBIZ-5572
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5572
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: Release Branch 11.04, SVN trunk, Release Branch 12.04
            Reporter: Praveen Agrawal


The two Ofbiz services from OrderServices.xml ('recreateOrderAdjustments' and 'loadCartFromOrder') are used when an order item is cancelled and calculate the promotion adjustment amount.

When an order item is cancelled:
The recreateOrderAdjustments service

    totals existing promotional amounts.
    calls the 'loadCartFromOrder' service.
    totals new promotional amounts
    compares the difference between existing and new promotional amounts and creates an order promotional adjustment on difference.

The loadCartFromOrder service

    adds valid order items to a shopping cart
    runs promotions
    adds 'existing' order item and order header promotional adjustments

The major issue with this work flow is in the loadCartFromOrder service loading the 'existing order item and order header promotional adjustment on to the cart.  The recreateOrder Adjustments service can then never make the correct comparison between existing and new promotional adjustments since these have been tallied in both services.



--
This message was sent by Atlassian JIRA
(v6.2#6252)