You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kgyrtkirk (via GitHub)" <gi...@apache.org> on 2025/04/24 11:16:21 UTC

[PR] Move ReadResourceActions validation earlier in QueryHandler (druid)

kgyrtkirk opened a new pull request, #17946:
URL: https://github.com/apache/druid/pull/17946

   I was poking around in `QueryHandler` and I can't figure out why [this validation](https://github.com/apache/druid/blob/d1989bf3b59b9d413ab1a84abf392e9e14202adc/sql/src/main/java/org/apache/druid/sql/calcite/planner/QueryHandler.java#L600-L612) should be postponed up until the resultsupplier is created - history goes back to 2021 so that didn't helped...
   
   I don't think anything break if I the check would be done earlier; possibly more 
   
   context:  doing it the other way could possibly skip this validation for future `QkSqlEngine`  (old planner + early `QueryDefinition` submission)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Move ReadResourceActions validation earlier in QueryHandler (druid)

Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #17946:
URL: https://github.com/apache/druid/pull/17946


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org