You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/16 21:46:49 UTC
[GitHub] [superset] robdiciuccio opened a new pull request #13658: deps: Bump pyyaml to latest
robdiciuccio opened a new pull request #13658:
URL: https://github.com/apache/superset/pull/13658
### SUMMARY
Bumps `pyyaml` dependency to latest version [[1](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-14343)].
Note that this dependency was updated manually as the `pip-compile-multi` upgrade workflow resulted in several errors, including:
```
ERROR! requirements/base.txt was not regenerated after changes in requirements/base.in.
Expecting: # SHA1:9eeea842b4dffc85a3611351dcb33aca43fbb9e9
Found: # SHA1:af5d6b34d3fc7fa4f5ad7fac81ce3161da042c2c
```
### TEST PLAN
Sanity check in test environment.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #13658: chore: bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-801327845
At Airbnb we successfully use `pip-compile-multi` to manage about half a dozen Python projects where we update all dependencies on a monthly cadence (via a cron).
Note `pip-compile-multi` also includes functionality to upgrade specific packages. In the interim the fix may be to create a PR to remedy the regression and add documentation (if not present) regarding how one should update the Python dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #13658: chore: bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-800905318
> Note that this dependency was updated manually as the pip-compile-multi upgrade workflow resulted in several errors, including:
>
> ERROR! requirements/base.txt was not regenerated after changes in requirements/base.in.
> Expecting: # SHA1:9eeea842b4dffc85a3611351dcb33aca43fbb9e9
> Found: # SHA1:af5d6b34d3fc7fa4f5ad7fac81ce3161da042c2c
I suspect this is due to the fact that other dependencies have been updated not using `pip-compile-multi`. We should really strive (I would actually go as far to say enforce) that all dependencies are _only_ updated via `pip-compile-multi` to ensure that the frozen set of requirements are viable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13658: chore: bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-801512026
Ephemeral environment shutdown and build artifacts deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13658: deps: Bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-800703282
# [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=h1) Report
> Merging [#13658](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=desc) (6357275) into [master](https://codecov.io/gh/apache/superset/commit/cd2f53ed7b1c4e10ac64a3374d751303c17c2618?el=desc) (cd2f53e) will **decrease** coverage by `5.48%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 6357275 differs from pull request most recent head 03c18b9. Consider uploading reports for the commit 03c18b9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13658 +/- ##
==========================================
- Coverage 76.78% 71.29% -5.49%
==========================================
Files 918 835 -83
Lines 46641 41726 -4915
Branches 5635 4329 -1306
==========================================
- Hits 35812 29748 -6064
- Misses 10684 11978 +1294
+ Partials 145 0 -145
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.59% <45.00%> (+2.72%)` | :arrow_up: |
| hive | `80.25% <90.90%> (+0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.55% <95.45%> (+0.01%)` | :arrow_up: |
| postgres | `80.61% <95.45%> (+0.01%)` | :arrow_up: |
| presto | `80.29% <90.90%> (+0.01%)` | :arrow_up: |
| python | `81.11% <95.45%> (+0.01%)` | :arrow_up: |
| sqlite | `80.22% <90.90%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `75.00% <ø> (ø)` | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.10% <0.00%> (+1.70%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `55.95% <40.00%> (-4.67%)` | :arrow_down: |
| [superset-frontend/src/common/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1NlbGVjdC50c3g=) | `66.66% <66.66%> (-33.34%)` | :arrow_down: |
| [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | `86.95% <75.00%> (-3.05%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <100.00%> (-30.45%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.71% <100.00%> (ø)` | |
| ... and [504 more](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=footer). Last update [cd2f53e...03c18b9](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13658: deps: Bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-800703282
# [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=h1) Report
> Merging [#13658](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=desc) (6357275) into [master](https://codecov.io/gh/apache/superset/commit/cd2f53ed7b1c4e10ac64a3374d751303c17c2618?el=desc) (cd2f53e) will **decrease** coverage by `5.55%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 6357275 differs from pull request most recent head 03c18b9. Consider uploading reports for the commit 03c18b9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13658 +/- ##
==========================================
- Coverage 76.78% 71.22% -5.56%
==========================================
Files 918 835 -83
Lines 46641 41726 -4915
Branches 5635 4329 -1306
==========================================
- Hits 35812 29719 -6093
- Misses 10684 12007 +1323
+ Partials 145 0 -145
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.59% <45.00%> (+2.72%)` | :arrow_up: |
| hive | `80.25% <90.90%> (+0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.55% <95.45%> (+0.01%)` | :arrow_up: |
| postgres | `80.61% <95.45%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.99% <95.45%> (-0.10%)` | :arrow_down: |
| sqlite | `80.22% <90.90%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `75.00% <ø> (ø)` | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.10% <0.00%> (+1.70%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `55.95% <40.00%> (-4.67%)` | :arrow_down: |
| [superset-frontend/src/common/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1NlbGVjdC50c3g=) | `66.66% <66.66%> (-33.34%)` | :arrow_down: |
| [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | `86.95% <75.00%> (-3.05%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <100.00%> (-30.45%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.71% <100.00%> (ø)` | |
| ... and [505 more](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=footer). Last update [cd2f53e...03c18b9](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio commented on pull request #13658: chore: bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-801241762
/testenv up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio commented on pull request #13658: chore: bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-801249329
> I suspect this is due to the fact that other dependencies have been updated not using pip-compile-multi.
That's definitely the case, and that has been due to difficulties using `pip-compile-multi`. I took a survey internally at Preset yesterday and a number of people reported issues with the current tooling. Not sure what we can do to get things back on track here without the unintended side-effect up upgrading all pins, or if there are viable alternatives to `pip-compile-multi`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13658: deps: Bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-800703282
# [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=h1) Report
> Merging [#13658](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=desc) (6357275) into [master](https://codecov.io/gh/apache/superset/commit/cd2f53ed7b1c4e10ac64a3374d751303c17c2618?el=desc) (cd2f53e) will **decrease** coverage by `10.80%`.
> The diff coverage is `69.04%`.
> :exclamation: Current head 6357275 differs from pull request most recent head 03c18b9. Consider uploading reports for the commit 03c18b9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13658 +/- ##
===========================================
- Coverage 76.78% 65.97% -10.81%
===========================================
Files 918 832 -86
Lines 46641 41671 -4970
Branches 5635 4305 -1330
===========================================
- Hits 35812 27494 -8318
- Misses 10684 14177 +3493
+ Partials 145 0 -145
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `43.86% <40.00%> (-10.01%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.55% <95.45%> (+0.01%)` | :arrow_up: |
| postgres | `80.61% <95.45%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.69% <95.45%> (-0.40%)` | :arrow_down: |
| sqlite | `80.22% <90.90%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `81.81% <ø> (-18.19%)` | :arrow_down: |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `8.33% <ø> (ø)` | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `87.50% <ø> (-7.74%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.10% <0.00%> (+1.70%)` | :arrow_up: |
| [superset-frontend/src/common/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1NlbGVjdC50c3g=) | `55.55% <33.33%> (-44.45%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `55.95% <40.00%> (-4.67%)` | :arrow_down: |
| [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | `86.95% <75.00%> (-3.05%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <100.00%> (-30.45%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.71% <100.00%> (ø)` | |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=footer). Last update [cd2f53e...03c18b9](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13658: deps: Bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-800703282
# [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=h1) Report
> Merging [#13658](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=desc) (6357275) into [master](https://codecov.io/gh/apache/superset/commit/cd2f53ed7b1c4e10ac64a3374d751303c17c2618?el=desc) (cd2f53e) will **decrease** coverage by `5.55%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 6357275 differs from pull request most recent head 03c18b9. Consider uploading reports for the commit 03c18b9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13658 +/- ##
==========================================
- Coverage 76.78% 71.22% -5.56%
==========================================
Files 918 835 -83
Lines 46641 41726 -4915
Branches 5635 4329 -1306
==========================================
- Hits 35812 29719 -6093
- Misses 10684 12007 +1323
+ Partials 145 0 -145
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.59% <45.00%> (+2.72%)` | :arrow_up: |
| hive | `80.23% <90.90%> (-0.01%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.55% <95.45%> (+0.01%)` | :arrow_up: |
| postgres | `80.61% <95.45%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.99% <95.45%> (-0.10%)` | :arrow_down: |
| sqlite | `80.22% <90.90%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `75.00% <ø> (ø)` | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.10% <0.00%> (+1.70%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `55.95% <40.00%> (-4.67%)` | :arrow_down: |
| [superset-frontend/src/common/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1NlbGVjdC50c3g=) | `66.66% <66.66%> (-33.34%)` | :arrow_down: |
| [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | `86.95% <75.00%> (-3.05%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <100.00%> (-30.45%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.71% <100.00%> (ø)` | |
| ... and [505 more](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=footer). Last update [cd2f53e...03c18b9](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio merged pull request #13658: chore: bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
robdiciuccio merged pull request #13658:
URL: https://github.com/apache/superset/pull/13658
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13658: chore: bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-801440236
@robdiciuccio Ephemeral environment spinning up at http://35.162.250.138:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13658: deps: Bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-800703282
# [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=h1) Report
> Merging [#13658](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=desc) (6357275) into [master](https://codecov.io/gh/apache/superset/commit/cd2f53ed7b1c4e10ac64a3374d751303c17c2618?el=desc) (cd2f53e) will **decrease** coverage by `5.73%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 6357275 differs from pull request most recent head 03c18b9. Consider uploading reports for the commit 03c18b9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13658 +/- ##
==========================================
- Coverage 76.78% 71.04% -5.74%
==========================================
Files 918 835 -83
Lines 46641 41726 -4915
Branches 5635 4329 -1306
==========================================
- Hits 35812 29644 -6168
- Misses 10684 12082 +1398
+ Partials 145 0 -145
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.59% <45.00%> (+2.72%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.55% <95.45%> (+0.01%)` | :arrow_up: |
| postgres | `80.61% <95.45%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.69% <95.45%> (-0.40%)` | :arrow_down: |
| sqlite | `80.22% <90.90%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `75.00% <ø> (ø)` | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `100.00% <ø> (+4.76%)` | :arrow_up: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.10% <0.00%> (+1.70%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `55.95% <40.00%> (-4.67%)` | :arrow_down: |
| [superset-frontend/src/common/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1NlbGVjdC50c3g=) | `66.66% <66.66%> (-33.34%)` | :arrow_down: |
| [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | `86.95% <75.00%> (-3.05%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <100.00%> (-30.45%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.71% <100.00%> (ø)` | |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=footer). Last update [cd2f53e...03c18b9](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13658: deps: Bump pyyaml to latest
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13658:
URL: https://github.com/apache/superset/pull/13658#issuecomment-800703282
# [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=h1) Report
> Merging [#13658](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=desc) (6357275) into [master](https://codecov.io/gh/apache/superset/commit/cd2f53ed7b1c4e10ac64a3374d751303c17c2618?el=desc) (cd2f53e) will **increase** coverage by `3.91%`.
> The diff coverage is `95.45%`.
> :exclamation: Current head 6357275 differs from pull request most recent head 03c18b9. Consider uploading reports for the commit 03c18b9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13658 +/- ##
==========================================
+ Coverage 76.78% 80.69% +3.91%
==========================================
Files 918 310 -608
Lines 46641 25020 -21621
Branches 5635 0 -5635
==========================================
- Hits 35812 20190 -15622
+ Misses 10684 4830 -5854
+ Partials 145 0 -145
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.55% <95.45%> (+0.01%)` | :arrow_up: |
| postgres | `80.61% <95.45%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.69% <95.45%> (-0.40%)` | :arrow_down: |
| sqlite | `80.22% <90.90%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | `86.95% <75.00%> (-3.05%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.71% <100.00%> (ø)` | |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `93.87% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.62% <100.00%> (+0.63%)` | :arrow_up: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <100.00%> (+1.06%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.62% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [598 more](https://codecov.io/gh/apache/superset/pull/13658/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=footer). Last update [cd2f53e...03c18b9](https://codecov.io/gh/apache/superset/pull/13658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org