You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/10/13 01:39:32 UTC
Re: Review Request 72945: Ignored the directoy `/dev/nvidia-caps` when
globing Nvidia GPU devices.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/
-----------------------------------------------------------
(Updated Oct. 13, 2020, 9:39 a.m.)
Review request for mesos, Benjamin Mahler and Kevin Klues.
Changes
-------
Addressed review comments.
Summary (updated)
-----------------
Ignored the directoy `/dev/nvidia-caps` when globing Nvidia GPU devices.
Bugs: MESOS-10192
https://issues.apache.org/jira/browse/MESOS-10192
Repository: mesos
Description (updated)
-------
The directory `/dev/nvidia-caps` was introduced in CUDA 11.0, just
ignore it since we only care about the Nvidia GPU device files.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp a0be1026bdaf7d4bb33f41e4c7d45666bd61f005
Diff: https://reviews.apache.org/r/72945/diff/2/
Changes: https://reviews.apache.org/r/72945/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 72945: Ignored the directoy `/dev/nvidia-caps` when
globing Nvidia GPU devices.
Posted by Qian Zhang <zh...@gmail.com>.
> On Oct. 13, 2020, 9:48 a.m., Benjamin Mahler wrote:
> > The part that's not clear is why we can safely ignore it. If we don't have a solid answer, perhaps just add a TODO to figure out what we should do with it?
Agreed.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/#review222030
-----------------------------------------------------------
On Oct. 13, 2020, 9:39 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72945/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2020, 9:39 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Kevin Klues.
>
>
> Bugs: MESOS-10192
> https://issues.apache.org/jira/browse/MESOS-10192
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The directory `/dev/nvidia-caps` was introduced in CUDA 11.0, just
> ignore it since we only care about the Nvidia GPU device files.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/gpu/isolator.cpp a0be1026bdaf7d4bb33f41e4c7d45666bd61f005
>
>
> Diff: https://reviews.apache.org/r/72945/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72945: Ignored the directoy `/dev/nvidia-caps` when
globing Nvidia GPU devices.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/#review222030
-----------------------------------------------------------
Ship it!
The part that's not clear is why we can safely ignore it. If we don't have a solid answer, perhaps just add a TODO to figure out what we should do with it?
- Benjamin Mahler
On Oct. 13, 2020, 1:39 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72945/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2020, 1:39 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Kevin Klues.
>
>
> Bugs: MESOS-10192
> https://issues.apache.org/jira/browse/MESOS-10192
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The directory `/dev/nvidia-caps` was introduced in CUDA 11.0, just
> ignore it since we only care about the Nvidia GPU device files.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/gpu/isolator.cpp a0be1026bdaf7d4bb33f41e4c7d45666bd61f005
>
>
> Diff: https://reviews.apache.org/r/72945/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72945: Ignored the directoy `/dev/nvidia-caps` when
globing Nvidia GPU devices.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/#review222174
-----------------------------------------------------------
Here is a reference as to what this folder is used for:
https://docs.google.com/document/d/194A-Hg3mLlIW4eo2BSUcGKpzZf2ciX47eoH5T-WZNXo/edit#
- Kevin Klues
On Oct. 13, 2020, 2:31 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72945/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2020, 2:31 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Kevin Klues.
>
>
> Bugs: MESOS-10192
> https://issues.apache.org/jira/browse/MESOS-10192
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The directory `/dev/nvidia-caps` was introduced in CUDA 11.0, just
> ignore it since we only care about the Nvidia GPU device files.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/gpu/isolator.cpp a0be1026bdaf7d4bb33f41e4c7d45666bd61f005
>
>
> Diff: https://reviews.apache.org/r/72945/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72945: Ignored the directoy `/dev/nvidia-caps` when
globing Nvidia GPU devices.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/
-----------------------------------------------------------
(Updated Oct. 13, 2020, 10:31 a.m.)
Review request for mesos, Benjamin Mahler and Kevin Klues.
Changes
-------
Added a TODO.
Bugs: MESOS-10192
https://issues.apache.org/jira/browse/MESOS-10192
Repository: mesos
Description
-------
The directory `/dev/nvidia-caps` was introduced in CUDA 11.0, just
ignore it since we only care about the Nvidia GPU device files.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp a0be1026bdaf7d4bb33f41e4c7d45666bd61f005
Diff: https://reviews.apache.org/r/72945/diff/3/
Changes: https://reviews.apache.org/r/72945/diff/2-3/
Testing
-------
sudo make check
Thanks,
Qian Zhang