[GitHub] [hadoop] liuml07 commented on a diff in pull request #5334: HDFS-16902 Add Namenode status to BPServiceActor metrics and improve logging in offerservice

["liuml07 (via GitHub)" <gi...@apache.org>]

liuml07 commented on code in PR #5334:
URL: https://github.com/apache/hadoop/pull/5334#discussion_r1093890563


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java:
##########
@@ -202,6 +202,7 @@ private String getNameNodeAddress() {
   Map<String, String> getActorInfoMap() {
     final Map<String, String> info = new HashMap<String, String>();
     info.put("NamenodeAddress", getNameNodeAddress());
+    info.put("NamenodeState", state.toString());

Review Comment:
   nit: is it better to name it `NameNodeHaState`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org