You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "David Kennedy (JIRA)" <ji...@apache.org> on 2006/06/30 21:44:29 UTC
[jira] Created: (JCR-472) Wrap IllegalArgumentException from UUID
when bad ID passed to Session.getNodeByUUID
Wrap IllegalArgumentException from UUID when bad ID passed to Session.getNodeByUUID
-----------------------------------------------------------------------------------
Key: JCR-472
URL: http://issues.apache.org/jira/browse/JCR-472
Project: Jackrabbit
Type: Improvement
Components: core
Versions: 1.0, 1.0.1, 1.1, 0.9
Environment: WinXP
Reporter: David Kennedy
Hi,
On 6/30/06, David Kennedy <da...@us.ibm.com> wrote:
> When invoking session.getNodeByUUID and passing an invalid ID, an
> IllegalArgumentException is thrown. Should this be wrapped in an
> ItemNotFoundException or RepositoryException by SessionImpl?
Good point, an ItemNotFoundException would probably be best. Could you
please file a Jira issue for this?
BR,
Jukka Zitting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-472) Wrap IllegalArgumentException from UUID
when bad ID passed to Session.getNodeByUUID
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-472?page=all ]
Jukka Zitting updated JCR-472:
------------------------------
Attachment: invalid-uuid.r418741.patch
Stefan:
> think ItemNotFoundException is misleading and inconsistent, RepositoryException would IMO be more appropriate.
OK, that's reasonable. Attached a modified patch (invalid-uuid.r418741.patch) that throws a RepositoryException.
> Wrap IllegalArgumentException from UUID when bad ID passed to Session.getNodeByUUID
> -----------------------------------------------------------------------------------
>
> Key: JCR-472
> URL: http://issues.apache.org/jira/browse/JCR-472
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Versions: 1.0, 1.0.1, 0.9
> Environment: WinXP
> Reporter: David Kennedy
> Assignee: Jukka Zitting
> Attachments: invalid-uuid.r418656.patch, invalid-uuid.r418741.patch
>
> Hi,
> On 6/30/06, David Kennedy <da...@us.ibm.com> wrote:
> > When invoking session.getNodeByUUID and passing an invalid ID, an
> > IllegalArgumentException is thrown. Should this be wrapped in an
> > ItemNotFoundException or RepositoryException by SessionImpl?
> Good point, an ItemNotFoundException would probably be best. Could you
> please file a Jira issue for this?
> BR,
> Jukka Zitting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-472) Wrap IllegalArgumentException from UUID
when bad ID passed to Session.getNodeByUUID
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-472?page=comments#action_12421039 ]
Tobias Bocanegra commented on JCR-472:
--------------------------------------
+1 go ahead
> Wrap IllegalArgumentException from UUID when bad ID passed to Session.getNodeByUUID
> -----------------------------------------------------------------------------------
>
> Key: JCR-472
> URL: http://issues.apache.org/jira/browse/JCR-472
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Versions: 1.0, 1.0.1, 0.9
> Environment: WinXP
> Reporter: David Kennedy
> Assignee: Jukka Zitting
> Attachments: invalid-uuid.r418656.patch, invalid-uuid.r418741.patch
>
> Hi,
> On 6/30/06, David Kennedy <da...@us.ibm.com> wrote:
> > When invoking session.getNodeByUUID and passing an invalid ID, an
> > IllegalArgumentException is thrown. Should this be wrapped in an
> > ItemNotFoundException or RepositoryException by SessionImpl?
> Good point, an ItemNotFoundException would probably be best. Could you
> please file a Jira issue for this?
> BR,
> Jukka Zitting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-472) Wrap IllegalArgumentException from UUID
when bad ID passed to Session.getNodeByUUID
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-472?page=comments#action_12421043 ]
Stefan Guggisberg commented on JCR-472:
---------------------------------------
+1 for applying the patch
> Wrap IllegalArgumentException from UUID when bad ID passed to Session.getNodeByUUID
> -----------------------------------------------------------------------------------
>
> Key: JCR-472
> URL: http://issues.apache.org/jira/browse/JCR-472
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Versions: 1.0, 1.0.1, 0.9
> Environment: WinXP
> Reporter: David Kennedy
> Assignee: Jukka Zitting
> Attachments: invalid-uuid.r418656.patch, invalid-uuid.r418741.patch
>
> Hi,
> On 6/30/06, David Kennedy <da...@us.ibm.com> wrote:
> > When invoking session.getNodeByUUID and passing an invalid ID, an
> > IllegalArgumentException is thrown. Should this be wrapped in an
> > ItemNotFoundException or RepositoryException by SessionImpl?
> Good point, an ItemNotFoundException would probably be best. Could you
> please file a Jira issue for this?
> BR,
> Jukka Zitting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-472) Wrap IllegalArgumentException from UUID
when bad ID passed to Session.getNodeByUUID
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-472?page=all ]
Jukka Zitting updated JCR-472:
------------------------------
Version: (was: 1.1)
Assign To: Jukka Zitting
> Wrap IllegalArgumentException from UUID when bad ID passed to Session.getNodeByUUID
> -----------------------------------------------------------------------------------
>
> Key: JCR-472
> URL: http://issues.apache.org/jira/browse/JCR-472
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Versions: 1.0, 1.0.1, 0.9
> Environment: WinXP
> Reporter: David Kennedy
> Assignee: Jukka Zitting
>
> Hi,
> On 6/30/06, David Kennedy <da...@us.ibm.com> wrote:
> > When invoking session.getNodeByUUID and passing an invalid ID, an
> > IllegalArgumentException is thrown. Should this be wrapped in an
> > ItemNotFoundException or RepositoryException by SessionImpl?
> Good point, an ItemNotFoundException would probably be best. Could you
> please file a Jira issue for this?
> BR,
> Jukka Zitting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-472) Wrap IllegalArgumentException from UUID
when bad ID passed to Session.getNodeByUUID
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-472?page=comments#action_12418918 ]
Stefan Guggisberg commented on JCR-472:
---------------------------------------
think ItemNotFoundException is misleading and inconsistent, RepositoryException
would IMO be more appropriate. api methods in jackrabbit that take path
arguments throw RepositoryException rather than PathNotFoundException
if the path format is incorrect.
> Wrap IllegalArgumentException from UUID when bad ID passed to Session.getNodeByUUID
> -----------------------------------------------------------------------------------
>
> Key: JCR-472
> URL: http://issues.apache.org/jira/browse/JCR-472
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Versions: 1.0, 1.0.1, 0.9
> Environment: WinXP
> Reporter: David Kennedy
> Assignee: Jukka Zitting
> Attachments: invalid-uuid.r418656.patch
>
> Hi,
> On 6/30/06, David Kennedy <da...@us.ibm.com> wrote:
> > When invoking session.getNodeByUUID and passing an invalid ID, an
> > IllegalArgumentException is thrown. Should this be wrapped in an
> > ItemNotFoundException or RepositoryException by SessionImpl?
> Good point, an ItemNotFoundException would probably be best. Could you
> please file a Jira issue for this?
> BR,
> Jukka Zitting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-472) Wrap IllegalArgumentException from UUID
when bad ID passed to Session.getNodeByUUID
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-472?page=comments#action_12421036 ]
Jukka Zitting commented on JCR-472:
-----------------------------------
> Attached a modified patch (invalid-uuid.r418741.patch) that throws a RepositoryException.
Any objections to applying this change? Tobias?
> Wrap IllegalArgumentException from UUID when bad ID passed to Session.getNodeByUUID
> -----------------------------------------------------------------------------------
>
> Key: JCR-472
> URL: http://issues.apache.org/jira/browse/JCR-472
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Versions: 1.0, 1.0.1, 0.9
> Environment: WinXP
> Reporter: David Kennedy
> Assignee: Jukka Zitting
> Attachments: invalid-uuid.r418656.patch, invalid-uuid.r418741.patch
>
> Hi,
> On 6/30/06, David Kennedy <da...@us.ibm.com> wrote:
> > When invoking session.getNodeByUUID and passing an invalid ID, an
> > IllegalArgumentException is thrown. Should this be wrapped in an
> > ItemNotFoundException or RepositoryException by SessionImpl?
> Good point, an ItemNotFoundException would probably be best. Could you
> please file a Jira issue for this?
> BR,
> Jukka Zitting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-472) Wrap IllegalArgumentException from UUID
when bad ID passed to Session.getNodeByUUID
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-472?page=all ]
Jukka Zitting updated JCR-472:
------------------------------
Attachment: invalid-uuid.r418656.patch
Attached a proposed fix for this.
> Wrap IllegalArgumentException from UUID when bad ID passed to Session.getNodeByUUID
> -----------------------------------------------------------------------------------
>
> Key: JCR-472
> URL: http://issues.apache.org/jira/browse/JCR-472
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Versions: 1.0, 1.0.1, 0.9
> Environment: WinXP
> Reporter: David Kennedy
> Assignee: Jukka Zitting
> Attachments: invalid-uuid.r418656.patch
>
> Hi,
> On 6/30/06, David Kennedy <da...@us.ibm.com> wrote:
> > When invoking session.getNodeByUUID and passing an invalid ID, an
> > IllegalArgumentException is thrown. Should this be wrapped in an
> > ItemNotFoundException or RepositoryException by SessionImpl?
> Good point, an ItemNotFoundException would probably be best. Could you
> please file a Jira issue for this?
> BR,
> Jukka Zitting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JCR-472) Wrap IllegalArgumentException from UUID
when bad ID passed to Session.getNodeByUUID
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-472?page=all ]
Jukka Zitting resolved JCR-472.
-------------------------------
Fix Version/s: 1.1
Resolution: Fixed
Fixed in revision 423073.
> Wrap IllegalArgumentException from UUID when bad ID passed to Session.getNodeByUUID
> -----------------------------------------------------------------------------------
>
> Key: JCR-472
> URL: http://issues.apache.org/jira/browse/JCR-472
> Project: Jackrabbit
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.0, 1.0.1, 0.9
> Environment: WinXP
> Reporter: David Kennedy
> Assigned To: Jukka Zitting
> Fix For: 1.1
>
> Attachments: invalid-uuid.r418656.patch, invalid-uuid.r418741.patch
>
>
> Hi,
> On 6/30/06, David Kennedy <da...@us.ibm.com> wrote:
> > When invoking session.getNodeByUUID and passing an invalid ID, an
> > IllegalArgumentException is thrown. Should this be wrapped in an
> > ItemNotFoundException or RepositoryException by SessionImpl?
> Good point, an ItemNotFoundException would probably be best. Could you
> please file a Jira issue for this?
> BR,
> Jukka Zitting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira