You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/09 16:32:59 UTC
[GitHub] [cloudstack-primate] RitchieVincent opened a new pull request #100:
[WIP] - Resource view style/layout improvement
RitchieVincent opened a new pull request #100: [WIP] - Resource view style/layout improvement
URL: https://github.com/apache/cloudstack-primate/pull/100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #100: [WIP] -
Resource view style/layout improvement
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #100: [WIP] - Resource view style/layout improvement
URL: https://github.com/apache/cloudstack-primate/pull/100#issuecomment-572901594
@RitchieVincent I reviewed and made some changes (see https://github.com/apache/cloudstack-primate/pull/100/commits/90a1e223e81fe45b741c2d0f9111fa5a56eb50e6), kindly review my changes around `a-progress`, and fix all the a-progress to show up to fill the width leave some place on left and right side.
This is what it looks now:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #100: [WIP]
- Resource view style/layout improvement
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #100: [WIP] - Resource view style/layout improvement
URL: https://github.com/apache/cloudstack-primate/pull/100#issuecomment-574087118
> @RitchieVincent ping - can you address styling issues?
Should be all good to go now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #100: Resource view
style/layout improvement
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #100: Resource view style/layout improvement
URL: https://github.com/apache/cloudstack-primate/pull/100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #100: [WIP]
- Resource view style/layout improvement
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #100: [WIP] - Resource view style/layout improvement
URL: https://github.com/apache/cloudstack-primate/pull/100#issuecomment-574602296
> @RitchieVincent the issues have not been addressed yet:
>
> 1. The width and label issue is not fixed for all a-progress, for example in zone/cluster:
> 
> 2. The issue of buttons on the bottom of a nic description block in the instance hardware tab:
> 
The second issue (buttons) should already be fixed, I applied that fix yesterday in #a11f6f9. Could you let me know if you're still seeing the issue, and if so, where?
The progress bar issue is also fixed now, along with a couple of other minor tweaks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #100: [WIP] -
Resource view style/layout improvement
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #100: [WIP] - Resource view style/layout improvement
URL: https://github.com/apache/cloudstack-primate/pull/100#issuecomment-573999190
@RitchieVincent ping - can you address styling issues?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #100: [WIP] -
Resource view style/layout improvement
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #100: [WIP] - Resource view style/layout improvement
URL: https://github.com/apache/cloudstack-primate/pull/100#issuecomment-574523459
@RitchieVincent the issues have not been addressed yet:
1. The width and label issue is not fixed for all a-progress, for example in zone/cluster:
2. The issue of buttons on the bottom of a nic description block in the instance hardware tab:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services