You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2011/01/26 12:47:00 UTC

svn commit: r1063683 - in /james/imap/trunk: api/src/main/java/org/apache/james/imap/api/message/request/ message/src/main/java/org/apache/james/imap/decode/ message/src/main/java/org/apache/james/imap/decode/base/ message/src/main/java/org/apache/jame...

Author: norman
Date: Wed Jan 26 11:47:00 2011
New Revision: 1063683

URL: http://svn.apache.org/viewvc?rev=1063683&view=rev
Log:
ImapRequest should extend ImapMessage and MessagingImapCommandParser should extends ImapCommandParser

Modified:
    james/imap/trunk/api/src/main/java/org/apache/james/imap/api/message/request/ImapRequest.java
    james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/MessagingImapCommandParser.java
    james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/base/AbstractImapCommandParser.java
    james/imap/trunk/message/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java

Modified: james/imap/trunk/api/src/main/java/org/apache/james/imap/api/message/request/ImapRequest.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/api/src/main/java/org/apache/james/imap/api/message/request/ImapRequest.java?rev=1063683&r1=1063682&r2=1063683&view=diff
==============================================================================
--- james/imap/trunk/api/src/main/java/org/apache/james/imap/api/message/request/ImapRequest.java (original)
+++ james/imap/trunk/api/src/main/java/org/apache/james/imap/api/message/request/ImapRequest.java Wed Jan 26 11:47:00 2011
@@ -20,12 +20,13 @@
 package org.apache.james.imap.api.message.request;
 
 import org.apache.james.imap.api.ImapCommand;
+import org.apache.james.imap.api.ImapMessage;
 
 /**
  * The actual Imap request
  *
  */
-public interface ImapRequest {
+public interface ImapRequest extends ImapMessage{
 
     /**
      * Gets the IMAP command whose execution is requested by the client.

Modified: james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/MessagingImapCommandParser.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/MessagingImapCommandParser.java?rev=1063683&r1=1063682&r2=1063683&view=diff
==============================================================================
--- james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/MessagingImapCommandParser.java (original)
+++ james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/MessagingImapCommandParser.java Wed Jan 26 11:47:00 2011
@@ -20,7 +20,7 @@ package org.apache.james.imap.decode;
 
 import org.apache.james.imap.api.message.response.StatusResponseFactory;
 
-public interface MessagingImapCommandParser {
+public interface MessagingImapCommandParser extends ImapCommandParser{
 
   
     public abstract StatusResponseFactory getStatusResponseFactory();

Modified: james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/base/AbstractImapCommandParser.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/base/AbstractImapCommandParser.java?rev=1063683&r1=1063682&r2=1063683&view=diff
==============================================================================
--- james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/base/AbstractImapCommandParser.java (original)
+++ james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/base/AbstractImapCommandParser.java Wed Jan 26 11:47:00 2011
@@ -25,7 +25,6 @@ import org.apache.james.imap.api.display
 import org.apache.james.imap.api.message.response.StatusResponseFactory;
 import org.apache.james.imap.api.process.ImapSession;
 import org.apache.james.imap.decode.DecodingException;
-import org.apache.james.imap.decode.ImapCommandParser;
 import org.apache.james.imap.decode.ImapRequestLineReader;
 import org.apache.james.imap.decode.MessagingImapCommandParser;
 
@@ -36,7 +35,7 @@ import org.apache.james.imap.decode.Mess
  * 
  * @version $Revision: 109034 $
  */
-public abstract class AbstractImapCommandParser implements ImapCommandParser, MessagingImapCommandParser {
+public abstract class AbstractImapCommandParser implements MessagingImapCommandParser {
     
     private final ImapCommand command;
 
@@ -52,10 +51,18 @@ public abstract class AbstractImapComman
     }
 
 
+    /*
+     * (non-Javadoc)
+     * @see org.apache.james.imap.decode.MessagingImapCommandParser#getStatusResponseFactory()
+     */
     public final StatusResponseFactory getStatusResponseFactory() {
         return statusResponseFactory;
     }
 
+    /*
+     * (non-Javadoc)
+     * @see org.apache.james.imap.decode.MessagingImapCommandParser#setStatusResponseFactory(org.apache.james.imap.api.message.response.StatusResponseFactory)
+     */
     public final void setStatusResponseFactory(
             StatusResponseFactory statusResponseFactory) {
         this.statusResponseFactory = statusResponseFactory;

Modified: james/imap/trunk/message/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/message/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java?rev=1063683&r1=1063682&r2=1063683&view=diff
==============================================================================
--- james/imap/trunk/message/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java (original)
+++ james/imap/trunk/message/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java Wed Jan 26 11:47:00 2011
@@ -19,14 +19,13 @@
 package org.apache.james.imap.message.request;
 
 import org.apache.james.imap.api.ImapCommand;
-import org.apache.james.imap.api.ImapMessage;
 import org.apache.james.imap.api.message.request.ImapRequest;
 
 /**
  * Abstract base class for {@link ImapRequest} implementations
  *
  */
-abstract public class AbstractImapRequest implements ImapMessage, ImapRequest {
+abstract public class AbstractImapRequest implements ImapRequest {
 
     private final String tag;
 



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org