You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/12/30 16:05:11 UTC
[kudu-CR](branch-1.18.x) [thirdparty] fix building rapidjson with GCC13
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22281
Change subject: [thirdparty] fix building rapidjson with GCC13
......................................................................
[thirdparty] fix building rapidjson with GCC13
GCC13 (G++13) is the default system compiler on contemporary Linux OS
flavors such as Ubuntu 24.04 LTS. With this patch it's now possible
to compile rapidjson on Ubuntu 24.04 LTS.
This patch picks up a couple of relevant patches from the rapidjson's
git repository. Probably, it's time to refresh rapidjson with very
recent updates overall, but it would require extra testing to rule out
possible regressions.
Change-Id: I68008baf7abe6de1f1250a29a268fc732bbe2885
Reviewed-on: http://gerrit.cloudera.org:8080/22277
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit 30506e572d4b1e28cf302db475fae0a74b3dbcbc)
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/rapidjson-document-assignment-operator-00.patch
A thirdparty/patches/rapidjson-document-assignment-operator-01.patch
3 files changed, 42 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/22281/1
--
To view, visit http://gerrit.cloudera.org:8080/22281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68008baf7abe6de1f1250a29a268fc732bbe2885
Gerrit-Change-Number: 22281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.18.x) [thirdparty] fix building rapidjson with GCC13
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22281 )
Change subject: [thirdparty] fix building rapidjson with GCC13
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/885/
--
To view, visit http://gerrit.cloudera.org:8080/22281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I68008baf7abe6de1f1250a29a268fc732bbe2885
Gerrit-Change-Number: 22281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 30 Dec 2024 16:05:18 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [thirdparty] fix building rapidjson with GCC13
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22281 )
Change subject: [thirdparty] fix building rapidjson with GCC13
......................................................................
[thirdparty] fix building rapidjson with GCC13
GCC13 (G++13) is the default system compiler on contemporary Linux OS
flavors such as Ubuntu 24.04 LTS. With this patch it's now possible
to compile rapidjson on Ubuntu 24.04 LTS.
This patch picks up a couple of relevant patches from the rapidjson's
git repository. Probably, it's time to refresh rapidjson with very
recent updates overall, but it would require extra testing to rule out
possible regressions.
Change-Id: I68008baf7abe6de1f1250a29a268fc732bbe2885
Reviewed-on: http://gerrit.cloudera.org:8080/22277
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit 30506e572d4b1e28cf302db475fae0a74b3dbcbc)
Reviewed-on: http://gerrit.cloudera.org:8080/22281
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/rapidjson-document-assignment-operator-00.patch
A thirdparty/patches/rapidjson-document-assignment-operator-01.patch
3 files changed, 42 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I68008baf7abe6de1f1250a29a268fc732bbe2885
Gerrit-Change-Number: 22281
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.18.x) [thirdparty] fix building rapidjson with GCC13
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/22281 )
Change subject: [thirdparty] fix building rapidjson with GCC13
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I68008baf7abe6de1f1250a29a268fc732bbe2885
Gerrit-Change-Number: 22281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 31 Dec 2024 01:59:34 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [thirdparty] fix building rapidjson with GCC13
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22281 )
Change subject: [thirdparty] fix building rapidjson with GCC13
......................................................................
Patch Set 1: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/885/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/22281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I68008baf7abe6de1f1250a29a268fc732bbe2885
Gerrit-Change-Number: 22281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 30 Dec 2024 17:02:32 +0000
Gerrit-HasComments: No