You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/01 12:34:18 UTC
[GitHub] [incubator-pegasus] GehaFearless opened a new pull request, #1094: Support Build on M1 MacOS
GehaFearless opened a new pull request, #1094:
URL: https://github.com/apache/incubator-pegasus/pull/1094
### What problem does this PR solve? <!--add issue link with summary if exists-->
issue: https://github.com/apache/incubator-pegasus/issues/1093
patch relate by https://github.com/jemalloc/jemalloc/issues/1997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1094: feat: Support Build on M1 MacOS
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #1094:
URL: https://github.com/apache/incubator-pegasus/pull/1094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1094: feat: Support Build on M1 MacOS
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1094:
URL: https://github.com/apache/incubator-pegasus/pull/1094#issuecomment-1202253050
> > Did you encounter this problem? Testing your branch on my local mac m1.
>
> You should `export OPENSSL_ROOT_DIR="/usr/local/opt/openssl"`. Also you need `brew install snappy brew install lz4 brew install zstd brew install openssl@1.1`
Yes, reference to https://github.com/apache/incubator-pegasus/blob/master/.github/workflows/lint_and_test_cpp.yaml#L298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1094: feat: Support Build on M1 MacOS
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1094:
URL: https://github.com/apache/incubator-pegasus/pull/1094#issuecomment-1202882674
could you check why jemalloc hasn't been rebuilt?
https://github.com/apache/incubator-pegasus/runs/7624482151?check_suite_focus=true#step:5:31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] GehaFearless commented on pull request #1094: feat: Support Build on M1 MacOS
Posted by GitBox <gi...@apache.org>.
GehaFearless commented on PR #1094:
URL: https://github.com/apache/incubator-pegasus/pull/1094#issuecomment-1202178945
> ```
> CMake Error at /opt/homebrew/Cellar/cmake/3.23.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
> Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
> system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
> OPENSSL_INCLUDE_DIR)
> ```
>
> Did you encounter this problem? Testing your branch on my local mac m1.
You should `export OPENSSL_ROOT_DIR="/usr/local/opt/openssl"`.
Also you need `brew install snappy
brew install lz4
brew install zstd
brew install openssl@1.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje commented on pull request #1094: feat: Support Build on M1 MacOS
Posted by GitBox <gi...@apache.org>.
neverchanje commented on PR #1094:
URL: https://github.com/apache/incubator-pegasus/pull/1094#issuecomment-1202119650
```
CMake Error at /opt/homebrew/Cellar/cmake/3.23.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
OPENSSL_INCLUDE_DIR)
```
Did you encounter this problem? Testing on my local mac m1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1094: feat: Support Build on M1 MacOS
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1094:
URL: https://github.com/apache/incubator-pegasus/pull/1094#discussion_r935738679
##########
.licenserc.yaml:
##########
@@ -90,6 +90,7 @@ header:
- 'thirdparty/fix_libevent_for_macos.patch'
- 'thirdparty/fix_s2_for_aarch64.patch'
- 'thirdparty/fix_thrift_for_cpp11.patch'
+ - 'thirdparty/fix_jemalloc_for_m1_on_macos.patch'
Review Comment:
```suggestion
- 'thirdparty/fix_jemalloc_for_m1_on_macos.patch'
- 'thirdparty/fix_libevent_for_macos.patch'
- 'thirdparty/fix_s2_for_aarch64.patch'
- 'thirdparty/fix_thrift_for_cpp11.patch'
```
keep in lexicographic order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] GehaFearless commented on pull request #1094: feat: Support Build on M1 MacOS
Posted by GitBox <gi...@apache.org>.
GehaFearless commented on PR #1094:
URL: https://github.com/apache/incubator-pegasus/pull/1094#issuecomment-1203559171
> Details
https://github.com/apache/incubator-pegasus/runs/7644893971?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org