[jira] [Comment Edited] (FLINK-6725) make requiresOver as a contracted method in udagg

["Fabian Hueske (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026970#comment-16026970 ] 

Fabian Hueske edited comment on FLINK-6725 at 5/26/17 10:35 PM:
----------------------------------------------------------------

Seems that I wasn't fast enough to review and merge this. 
There is already a new RC and I don't think this issue qualifies as a blocking issue but is rather cosmetic. 

I have no strong opinion about whether the method should be implemented in {{AggregateFunction}} or just optional. While the other methods are optional for a variety of reasons (1) a user might not want to implement it, 2) it cannot be implemented, 3) its signature needs to be flexible, ...), the {{requiresOver()}} method can have a default implementation {{false}} and be simply overridden if necessary.

At the moment, we cannot merge it to the {{release-1.3}} because this would mean to break the interface in a bugfix release if the current RC is released as 1.3.0.
We could merge it to {{master}} for Flink 1.4.0 but might as well break the interface in 1.4.0, if the current RC is released.

In case there is another RC, we can merge the change if you think it is necessary.


was (Author: fhueske):
Seems that I wasn't fast enough to review and merge this. 
There is already a new RC and I don't think this issue qualifies as a blocking issue but is rather cosmetic. 

I have no strong opinion about whether the method should be implemented in `AggregateFunction` or just optional. While the other methods are optional for a variety of reasons (1) a user might not want to implement it, 2) it cannot be implemented, 3) its signature needs to be flexible, ...), the {{requiresOver()}} method can have a default implementation {{false}} and be simply overridden if necessary.

At the moment, we cannot merge it to the {{release-1.3}} because this would mean to break the interface in a bugfix release if the current RC is released as 1.3.0.
We could merge it to {{master}} for Flink 1.4.0 but might as well break the interface in 1.4.0, if the current RC is released.

In case there is another RC, we can merge the change if you think it is necessary.

> make requiresOver as a contracted method in udagg
> -------------------------------------------------
>
>                 Key: FLINK-6725
>                 URL: https://issues.apache.org/jira/browse/FLINK-6725
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>
> I realized requiresOver is defined in the udagg interface when I wrote up the udagg doc. I would like to put requiresOver as a contract method. This makes the entire udagg interface consistently and clean.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)