You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2015/12/27 21:42:58 UTC
[GitHub] incubator-zeppelin pull request: [Zeppelin 537] Improve behavior o...
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/573
[Zeppelin 537] Improve behavior of reloading notebooks from storage
### What is this PR for?
Improve behavior of reloading notebooks from storage
### What type of PR is it?
Improvement
### Is there a relevant Jira issue?
[ZEPPELIN-537](https://issues.apache.org/jira/browse/ZEPPELIN-537?jql=project%20%3D%20ZEPPELIN)
### How should this be tested?
1. Add new `notebookId/note.json` under `ZEPPELIN_HOME/notebook`
2. Click reload button next to 'Notebook'
3. Check if the new added note is loaded
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator-zeppelin ZEPPELIN-537
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #573
----
commit 6a803041c9aed9d43cd570fb21dec73cefd68c03
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-12-26T23:55:22Z
Reload notebooks from repository with reload button click event
commit 3fc9ad0dea215f725e9b401123be41eab3d5105a
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-12-27T01:50:01Z
Revert "ZEPPELIN-367 Sync with secondary storage when listing notebooks"
This reverts commit ae08e713e43ce9ebfb11f0f9cf7a7ea42885d677.
Conflicts:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/NotebookRepoSyncTest.java
commit b26dabf81803c5029dcdf4469da34e8a5d0f6443
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-12-27T01:53:46Z
Remove ZEPPELIN_NOTEBOOK_RELOAD_FROM_STORAGE env variable
commit b03cde26793004415d3a31ecb12d13d0910a1515
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-12-27T03:13:08Z
Sync with secondary storage when reload notebooks
commit 1f83f15f0601795fc42f1113cd104efcbde93a38
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-12-27T05:04:56Z
Modify test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 537] Improve behavior o...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/573#issuecomment-167723363
Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 537] Improve behavior o...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/573#issuecomment-167496955
Tested and LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 537] Improve behavior o...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/573#issuecomment-167744592
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 537] Improve behavior o...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/573#issuecomment-168462036
LGTM, merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 537] Improve behavior o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/573
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 537] Improve behavior o...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/573#issuecomment-167722761
@khalidhuseynov Keeping notebookRepo class for the flexibility makes perfect sense. I just addressed it please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---