You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/08/23 16:09:47 UTC
svn commit: r1865773 - in
/pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger:
PDFDebugger.java hexviewer/ASCIIPane.java hexviewer/HexEditor.java
Author: tilman
Date: Fri Aug 23 16:09:47 2019
New Revision: 1865773
URL: http://svn.apache.org/viewvc?rev=1865773&view=rev
Log:
PDFBOX-4071: SonarQube fix: these UI classes won't be serialized
Modified:
pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java
pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java
Modified: pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java?rev=1865773&r1=1865772&r2=1865773&view=diff
==============================================================================
--- pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java (original)
+++ pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java Fri Aug 23 16:09:47 2019
@@ -127,7 +127,7 @@ import org.apache.pdfbox.printing.PDFPag
* @author Ben Litchfield
* @author Khyrul Bashar
*/
-@SuppressWarnings({"serial","squid:MaximumInheritanceDepth"})
+@SuppressWarnings({"serial","squid:MaximumInheritanceDepth","squid:S1948"})
public class PDFDebugger extends JFrame
{
private static final Set<COSName> SPECIALCOLORSPACES =
@@ -146,7 +146,6 @@ public class PDFDebugger extends JFrame
private TreeStatusPane statusPane;
private RecentFiles recentFiles;
- @SuppressWarnings("squid:S1948")
private WindowPrefs windowPrefs;
private boolean isPageMode;
Modified: pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java?rev=1865773&r1=1865772&r2=1865773&view=diff
==============================================================================
--- pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java (original)
+++ pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java Fri Aug 23 16:09:47 2019
@@ -30,6 +30,7 @@ import javax.swing.JComponent;
* This class shows corresponding ASCII characters for bytes. For every 16 byte there is one line.
* This paints the only visible contents at one time.
*/
+@SuppressWarnings({"serial","squid:S1948"})
class ASCIIPane extends JComponent implements HexModelChangeListener
{
private final HexModel model;
Modified: pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java?rev=1865773&r1=1865772&r2=1865773&view=diff
==============================================================================
--- pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java (original)
+++ pdfbox/branches/issue45/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java Fri Aug 23 16:09:47 2019
@@ -45,6 +45,7 @@ import javax.swing.border.LineBorder;
*
* This class hosts all the UI components of Hex view and coordinates among them.
*/
+@SuppressWarnings({"serial","squid:S1948"})
class HexEditor extends JPanel implements SelectionChangeListener
{
private final HexModel model;