You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by Maziyar Boustani <bo...@apache.org> on 2013/07/10 02:07:20 UTC
Review Request 12376: Python test (unittest) for dataset.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12376/
-----------------------------------------------------------
Review request for Apache Open Climate.
Repository: climate
Description
-------
test_dataset.py is the separate file to test the dataset.py file.
Here I have tested attributes and all functions of dataset.py.
The more test cases we come up with, the better dataset.py would be.
So it would be great if you can collaborate with me here to come up with more test cases.
Diffs
-----
https://svn.apache.org/repos/asf/incubator/climate/trunk/test_dataset.py PRE-CREATION
Diff: https://reviews.apache.org/r/12376/diff/
Testing
-------
Here is the result of running the test_dataset.py
As it shows, 9 tests have been done and all were successful.
$ python test_dataset.py
.........
----------------------------------------------------------------------
Ran 9 tests in 0.005s
Thanks,
Maziyar Boustani
Re: Review Request 12376: Python test (unittest) for dataset.py
Posted by Cameron Goodale <go...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12376/#review23136
-----------------------------------------------------------
Mazi,
This looks like a good set of starter tests. We should next add in tests for how the Dataset Class will respond when it is given incorrect data. What if someone gives the Class a string instead of a numpy array? I would imagine it would throw an Exception, but we need to test that.
Other than a few typos it looks good.
- Cameron Goodale
On July 10, 2013, 12:07 a.m., Maziyar Boustani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12376/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 12:07 a.m.)
>
>
> Review request for Apache Open Climate.
>
>
> Repository: climate
>
>
> Description
> -------
>
> test_dataset.py is the separate file to test the dataset.py file.
> Here I have tested attributes and all functions of dataset.py.
> The more test cases we come up with, the better dataset.py would be.
> So it would be great if you can collaborate with me here to come up with more test cases.
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/climate/trunk/test_dataset.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12376/diff/
>
>
> Testing
> -------
>
> Here is the result of running the test_dataset.py
> As it shows, 9 tests have been done and all were successful.
>
>
> $ python test_dataset.py
> .........
> ----------------------------------------------------------------------
> Ran 9 tests in 0.005s
>
>
> Thanks,
>
> Maziyar Boustani
>
>