You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/05/11 20:42:23 UTC
[Bug 59489] New: Regression in JMeter 3.0 : Compressed responses
break keepalive management
https://bz.apache.org/bugzilla/show_bug.cgi?id=59489
Bug ID: 59489
Summary: Regression in JMeter 3.0 : Compressed responses break
keepalive management
Product: JMeter
Version: 3.0
Hardware: All
OS: All
Status: NEW
Severity: blocker
Priority: P2
Component: HTTP
Assignee: issues@jmeter.apache.org
Reporter: p.mouawad@ubik-ingenierie.com
Hello,
We have an issue in current 3.0 rc4 as seen by Rainer :
- https://issues.apache.org/jira/browse/HTTPCLIENT-1742
The issue is due to a behavioral change in HttpClient 4.5.2 vs
httpclient-4.2.6:
ResponseContentEncoding removes 3 headers from Response : Content-Encoding,
Content-Length, Content-MD5
JMeter uses DefaultRequestDirector which is replaced by MainClientExec
Now here is what happens:
At this line, PostProcessor run , leading to removal of 3 headers
https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/impl/client/DefaultRequestDirector.java#L496
At the next line, keepAlive management is run, but it's too late as headers
have been removed:
https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/impl/client/DefaultRequestDirector.java#L500
While in new HC Class ProtocolExec:
The keepAlive is managed in this
https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/execchain/ProtocolExec.java#L184
Which calls this:
https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/execchain/MainClientExec.java#L274
And Compression is managed afterwards in :
https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/execchain/ProtocolExec.java#L189
So no issue in HC4.5.2, but in JMeter. I think it's unfortunately a stopper for
the release.
Breaking KeepAlive is a big issue
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59489] Regression in JMeter 3.0 : Compressed responses break
keepalive management
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59489
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Thu May 12 06:09:21 2016
New Revision: 1743467
URL: http://svn.apache.org/viewvc?rev=1743467&view=rev
Log:
Bug 59489 - Regression in JMeter 3.0 : Compressed responses break keepalive
management
Take into account sebb note
INstanciate ArrayList only when needed
Bugzilla Id: 59489
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59489] Regression in JMeter nighlty build (before 3.0) :
Compressed responses break keepalive management
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59489
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Regression in JMeter 3.0 : |Regression in JMeter
|Compressed responses break |nighlty build (before 3.0)
|keepalive management |: Compressed responses
| |break keepalive management
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59489] Regression in JMeter 3.0 : Compressed responses break
keepalive management
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59489
--- Comment #1 from Sebb <se...@apache.org> ---
As per the dev list:
A much simpler way to restore the headers would
be to save them, call the parent method, then restore them.
No need to mess around with the context.
Basically that would revert the change made to HC4.5.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59489] Regression in JMeter 3.0 : Compressed responses break
keepalive management
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59489
--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Wed May 11 21:09:00 2016
New Revision: 1743429
URL: http://svn.apache.org/viewvc?rev=1743429&view=rev
Log:
Bug 59489 - Regression in JMeter 3.0 : Compressed responses break keepalive
management
Bugzilla Id: 59489
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
--
You are receiving this mail because:
You are the assignee for the bug.