You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "ruanwenjun (via GitHub)" <gi...@apache.org> on 2024/04/25 10:48:43 UTC
[I] [DSIP-34] Change required_approving_review_count to 2 [dolphinscheduler]
ruanwenjun opened a new issue, #15913:
URL: https://github.com/apache/dolphinscheduler/issues/15913
### Search before asking
- [X] I had searched in the [DSIP](https://github.com/apache/dolphinscheduler/issues/14102) and found no similar DSIP.
### Motivation
Right now, the minimal approve count is 1 in DS, this means once a pr receive an approve, then this PR can be merged. In fact, in most of merged PR, the approval is one.
While I don't agree with change the minimal ap to 2, currently only 1 ap can merge PRs leading to a lot of PRs being merged in a hurry. This make the project get a lot of changes only a small number of people(Maybe only one people) want.
So it's need to change the required_approving_review_count be larger than one.
### Design Detail
Change `required_approving_review_count ` in `.asf.yaml`
### Compatibility, Deprecation, and Migration Plan
Compatibility
### Test Plan
No
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [DSIP-34] Change required_approving_review_count to 2 [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun closed issue #15913: [DSIP-34] Change required_approving_review_count to 2
URL: https://github.com/apache/dolphinscheduler/issues/15913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org