You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maulin-vasavada (via GitHub)" <gi...@apache.org> on 2023/04/04 03:31:31 UTC
[GitHub] [cassandra] maulin-vasavada commented on a diff in pull request #2253: CASSANDRA-18124 Make keystore_password nullable
maulin-vasavada commented on code in PR #2253:
URL: https://github.com/apache/cassandra/pull/2253#discussion_r1156691234
##########
conf/cassandra.yaml:
##########
@@ -1360,6 +1360,7 @@ server_encryption_options:
# during upgrade to 4.0; otherwise, set to false.
legacy_ssl_storage_port_enabled: false
# Set to a valid keystore if internode_encryption is dc, rack or all
+ # For configurating PEM based key material, refer to https://cassandra.apache.org/doc/latest/cassandra/operating/security.html#using-pem-based-key-material
Review Comment:
One of the ask on the ticket was to include an example in comments for the PEM formatted keys. However, since we have client and server both options adding long repeated comments may not make sense hence I added a link like another http link I saw on the yaml document. Would love to hear from you and other members on this and get more direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org