You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/02/04 21:31:59 UTC
Review Request 43215: Added code to remove a process's endpoint help
strings upon termination.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43215/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-4552
https://issues.apache.org/jira/browse/MESOS-4552
Repository: mesos
Description
-------
Previously, the global help process would retain the help information
of processes even after they were termianted.
This commit adds code to remove these help strings.
Diffs
-----
3rdparty/libprocess/src/process.cpp 1672e081bd379cdf0467ea312f1798404f66eaa6
Diff: https://reviews.apache.org/r/43215/diff/
Testing
-------
Thanks,
Kevin Klues
Re: Review Request 43215: Added code to remove a process's endpoint
help strings upon termination.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43215/#review117959
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Feb. 5, 2016, 3:21 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43215/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 3:21 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4552
> https://issues.apache.org/jira/browse/MESOS-4552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the global help process would retain the help information
> of processes even after they were termianted.
>
> This commit adds code to remove these help strings.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 1672e081bd379cdf0467ea312f1798404f66eaa6
>
> Diff: https://reviews.apache.org/r/43215/diff/
>
>
> Testing
> -------
>
> Unit test in a subsequent commit.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 43215: Added code to remove a process's endpoint
help strings upon termination.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43215/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 3:21 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Updated based on comments made by bmahler offline.
Bugs: MESOS-4552
https://issues.apache.org/jira/browse/MESOS-4552
Repository: mesos
Description
-------
Previously, the global help process would retain the help information
of processes even after they were termianted.
This commit adds code to remove these help strings.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 1672e081bd379cdf0467ea312f1798404f66eaa6
Diff: https://reviews.apache.org/r/43215/diff/
Testing (updated)
-------
Unit test in a subsequent commit.
Thanks,
Kevin Klues