[Impala-ASF-CR] [PREVIEW] Unified backend test executable

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 )

Change subject: [PREVIEW] Unified backend test executable
......................................................................


Patch Set 1:

(2 comments)

Generally seems OK to me

http://gerrit.cloudera.org:8080/#/c/12124/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12124/1//COMMIT_MSG@29
PS1, Line 29: 
Does ctest -R still work?


http://gerrit.cloudera.org:8080/#/c/12124/1/bin/gen-backend-test-script.sh
File bin/gen-backend-test-script.sh:

http://gerrit.cloudera.org:8080/#/c/12124/1/bin/gen-backend-test-script.sh@30
PS1, Line 30: ${IMPALA_HOME}/bin/junit_prune.py -f "${IMPALA_BE_TEST_LOGS_DIR}/${TEST_EXEC_NAME}.xml"
This pruning might need a bit more explanation



-- 
To view, visit http://gerrit.cloudera.org:8080/12124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia03ef38719b1fbc0fe2025e16b7b3d3dd4488842
Gerrit-Change-Number: 12124
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Jan 2019 01:14:23 +0000
Gerrit-HasComments: Yes