You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/09/24 03:01:57 UTC

[GitHub] [singa] nudles opened a new pull request #798: Prepare for V3.1.0.RC1

nudles opened a new pull request #798:
URL: https://github.com/apache/singa/pull/798


   Fix some links and license issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] lgtm-com[bot] commented on pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #798:
URL: https://github.com/apache/singa/pull/798#issuecomment-698099915


   This pull request **introduces 7 alerts** and **fixes 16** when merging e1f346df67d37d36012243f412702f0a27a123bc into a00a23bbeb6731c6627f1f747c7176c5c5613dab - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-1aa5af736255e393ce37ef63b409ede6924126f1)
   
   **new alerts:**
   
   * 3 for Missing return statement
   * 2 for Testing equality to None
   * 1 for Unused import
   * 1 for Module is imported with &#39;import&#39; and &#39;import from&#39;
   
   **fixed alerts:**
   
   * 12 for Missing call to \_\_init\_\_ during object initialization
   * 2 for Unreachable code
   * 1 for Unnecessary pass
   * 1 for Unused local variable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] edited a comment on pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #798:
URL: https://github.com/apache/singa/pull/798#issuecomment-698083775


   # [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@a00a23b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/798/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #798   +/-   ##
   =========================================
     Coverage          ?   65.09%           
   =========================================
     Files             ?       86           
     Lines             ?     4804           
     Branches          ?        0           
   =========================================
     Hits              ?     3127           
     Misses            ?     1677           
     Partials          ?        0           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.09% <0.00%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=footer). Last update [a00a23b...b18a87e](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] lgtm-com[bot] commented on pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #798:
URL: https://github.com/apache/singa/pull/798#issuecomment-698099915


   This pull request **introduces 7 alerts** and **fixes 16** when merging e1f346df67d37d36012243f412702f0a27a123bc into a00a23bbeb6731c6627f1f747c7176c5c5613dab - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-1aa5af736255e393ce37ef63b409ede6924126f1)
   
   **new alerts:**
   
   * 3 for Missing return statement
   * 2 for Testing equality to None
   * 1 for Unused import
   * 1 for Module is imported with &#39;import&#39; and &#39;import from&#39;
   
   **fixed alerts:**
   
   * 12 for Missing call to \_\_init\_\_ during object initialization
   * 2 for Unreachable code
   * 1 for Unnecessary pass
   * 1 for Unused local variable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] joddiy merged pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
joddiy merged pull request #798:
URL: https://github.com/apache/singa/pull/798


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] edited a comment on pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #798:
URL: https://github.com/apache/singa/pull/798#issuecomment-698083775






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] commented on pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #798:
URL: https://github.com/apache/singa/pull/798#issuecomment-698083775


   # [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=h1) Report
   > Merging [#798](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=desc) into [master](https://codecov.io/gh/apache/singa/commit/f5a9cdfd9866851adf5e5909250add3f62acbf27?el=desc) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/798/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #798   +/-   ##
   =======================================
     Coverage   65.09%   65.09%           
   =======================================
     Files          86       86           
     Lines        4804     4804           
   =======================================
     Hits         3127     3127           
     Misses       1677     1677           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.09% <0.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/model/layer/activation.cc](https://codecov.io/gh/apache/singa/pull/798/diff?src=pr&el=tree#diff-c3JjL21vZGVsL2xheWVyL2FjdGl2YXRpb24uY2M=) | `90.38% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=footer). Last update [f5a9cdf...b18a87e](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] commented on pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #798:
URL: https://github.com/apache/singa/pull/798#issuecomment-698083775


   # [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=h1) Report
   > Merging [#798](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=desc) into [master](https://codecov.io/gh/apache/singa/commit/f5a9cdfd9866851adf5e5909250add3f62acbf27?el=desc) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/798/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #798   +/-   ##
   =======================================
     Coverage   65.09%   65.09%           
   =======================================
     Files          86       86           
     Lines        4804     4804           
   =======================================
     Hits         3127     3127           
     Misses       1677     1677           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.09% <0.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/model/layer/activation.cc](https://codecov.io/gh/apache/singa/pull/798/diff?src=pr&el=tree#diff-c3JjL21vZGVsL2xheWVyL2FjdGl2YXRpb24uY2M=) | `90.38% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=footer). Last update [f5a9cdf...b18a87e](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] edited a comment on pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #798:
URL: https://github.com/apache/singa/pull/798#issuecomment-698083775


   # [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@a00a23b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/798/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #798   +/-   ##
   =========================================
     Coverage          ?   65.09%           
   =========================================
     Files             ?       86           
     Lines             ?     4804           
     Branches          ?        0           
   =========================================
     Hits              ?     3127           
     Misses            ?     1677           
     Partials          ?        0           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.09% <0.00%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=footer). Last update [a00a23b...389bd56](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] joddiy merged pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
joddiy merged pull request #798:
URL: https://github.com/apache/singa/pull/798


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] edited a comment on pull request #798: Prepare for V3.1.0.RC1

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #798:
URL: https://github.com/apache/singa/pull/798#issuecomment-698083775


   # [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@a00a23b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/798/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #798   +/-   ##
   =========================================
     Coverage          ?   65.09%           
   =========================================
     Files             ?       86           
     Lines             ?     4804           
     Branches          ?        0           
   =========================================
     Hits              ?     3127           
     Misses            ?     1677           
     Partials          ?        0           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.09% <0.00%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=footer). Last update [a00a23b...e1f346d](https://codecov.io/gh/apache/singa/pull/798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org