[jira] [Commented] (KAFKA-3599) Minor code cleanup

["Matthias J. Sax (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251933#comment-15251933 ] 

Matthias J. Sax commented on KAFKA-3599:
----------------------------------------

[~guozhang] if I understand correctly, we remove {{equalsTo()}} and just use {{equals()}}. I also discovered, that {{Windows}} (plural, not singular) has {{equalsTo()}} as well, but the method is never used. For consistency, it might be good to remove {{equalsTo()}} from {{Windows}} completely or rename it to {{equals()}}? What do you think about it?

> Minor code cleanup
> ------------------
>
>                 Key: KAFKA-3599
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3599
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>              Labels: api
>
> - Clean up {{Window.equals()}} and {{Window.equalsTo()}}. Both do the same.
> - remove {{WindowStoreUtils}} from public API, ie, move to sub-package {{internals}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)