You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/12/08 21:50:12 UTC
Re: Review Request 40326: libprocess: Marked Boost as a "system"
header.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40326/#review109385
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Nov. 16, 2015, 8:47 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40326/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 8:47 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
>
>
> Bugs: MESOS-3799
> https://issues.apache.org/jira/browse/MESOS-3799
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 0adbe539afaf683e4a85582463a2930049a63998
> 3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4
> 3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3
>
> Diff: https://reviews.apache.org/r/40326/diff/
>
>
> Testing
> -------
>
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
>
> Note that the cmake build still emits boost-related warnings: I didn't try to fix this, since cmake emits other warnings that autotools suppresses (e.g., no-unused-local-typedefs).
>
>
> Thanks,
>
> Neil Conway
>
>