You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/07/21 17:17:38 UTC
Review Request 23740: Patch for KAFKA-1462
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23740/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1462
https://issues.apache.org/jira/browse/KAFKA-1462
Repository: kafka
Description
-------
Exclude request id from server-side request objects
Diffs
-----
core/src/main/scala/kafka/api/GenericRequestAndHeader.scala PRE-CREATION
core/src/main/scala/kafka/api/GenericRequestOrResponseAndHeader.scala fb022e8e740ba7b8a0d855e00809d23d1fa1ad36
core/src/main/scala/kafka/api/HeartbeatRequestAndHeader.scala 932418bd34051c884f732d5a87e317c7a6fca0fc
core/src/main/scala/kafka/api/HeartbeatResponseAndHeader.scala 556f38dd2a5b4c53b9e510918243684808f6adf2
core/src/main/scala/kafka/api/JoinGroupRequestAndHeader.scala 9aea28c2d4a628bddf2643e89d5be455abca69da
core/src/main/scala/kafka/api/JoinGroupResponseAndHeader.scala 7389ae6c3cbc195466c5aa58aaf7ec0f5a722c11
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala 847a36bfef4ef268823e80e028d18a7e2bf936fd
Diff: https://reviews.apache.org/r/23740/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 23740: Patch for KAFKA-1462
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23740/#review48315
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On July 21, 2014, 3:17 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23740/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 3:17 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1462
> https://issues.apache.org/jira/browse/KAFKA-1462
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Exclude request id from server-side request objects
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/GenericRequestAndHeader.scala PRE-CREATION
> core/src/main/scala/kafka/api/GenericRequestOrResponseAndHeader.scala fb022e8e740ba7b8a0d855e00809d23d1fa1ad36
> core/src/main/scala/kafka/api/HeartbeatRequestAndHeader.scala 932418bd34051c884f732d5a87e317c7a6fca0fc
> core/src/main/scala/kafka/api/HeartbeatResponseAndHeader.scala 556f38dd2a5b4c53b9e510918243684808f6adf2
> core/src/main/scala/kafka/api/JoinGroupRequestAndHeader.scala 9aea28c2d4a628bddf2643e89d5be455abca69da
> core/src/main/scala/kafka/api/JoinGroupResponseAndHeader.scala 7389ae6c3cbc195466c5aa58aaf7ec0f5a722c11
> core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala 847a36bfef4ef268823e80e028d18a7e2bf936fd
>
> Diff: https://reviews.apache.org/r/23740/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 23740: Patch for KAFKA-1462
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23740/#review48309
-----------------------------------------------------------
Ship it!
Ship It!
- Jay Kreps
On July 21, 2014, 3:17 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23740/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 3:17 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1462
> https://issues.apache.org/jira/browse/KAFKA-1462
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Exclude request id from server-side request objects
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/GenericRequestAndHeader.scala PRE-CREATION
> core/src/main/scala/kafka/api/GenericRequestOrResponseAndHeader.scala fb022e8e740ba7b8a0d855e00809d23d1fa1ad36
> core/src/main/scala/kafka/api/HeartbeatRequestAndHeader.scala 932418bd34051c884f732d5a87e317c7a6fca0fc
> core/src/main/scala/kafka/api/HeartbeatResponseAndHeader.scala 556f38dd2a5b4c53b9e510918243684808f6adf2
> core/src/main/scala/kafka/api/JoinGroupRequestAndHeader.scala 9aea28c2d4a628bddf2643e89d5be455abca69da
> core/src/main/scala/kafka/api/JoinGroupResponseAndHeader.scala 7389ae6c3cbc195466c5aa58aaf7ec0f5a722c11
> core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala 847a36bfef4ef268823e80e028d18a7e2bf936fd
>
> Diff: https://reviews.apache.org/r/23740/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>