You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Brock Noland <br...@cloudera.com> on 2013/07/20 18:48:18 UTC
Review Request 12790: HIVE-4892: PTest2 cleanup after merge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12790/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-4892
https://issues.apache.org/jira/browse/HIVE-4892
Repository: hive-git
Description
-------
Fixes the following issues:
README is out of date
Need to limit the number of failed source directories we copy back from the slaves
when looking for TEST-*.xml files we look at both the log directory (good) and the failed source directories (bad) therefore duplicating failures in jenkins report
We need to process bad hosts in the finally block of PTest.run (HIVE-4882)
Need a mechanism to clean the ivy and maven cache (HIVE-4882)
PTest2 fails to publish a comment to a JIRA sometimes (HIVE-4889)
Now that PTest2 is committed to the source tree it's copying in our TEST-SomeTest*.xml files
Diffs
-----
testutils/ptest2/README.md a483851
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java d6e9ce3
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java b41726a
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java 9b2125c
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/ExecutionPhase.java b5d7909
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/HostExecutor.java 34a087c
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java 09c6d66
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JUnitReportParser.java 50cce25
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java f4f5076
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/ReportingPhase.java 023c26b
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/QFileTestBatch.java 722312a
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java fef2a3e
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/UnitTestBatch.java e911304
testutils/ptest2/src/main/resources/batch-exec.vm a35fcec
testutils/ptest2/src/main/resources/source-prep.vm 7a92272
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestExecutionPhase.java eec5560
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestHostExecutor.java 6fc649a
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestReportingPhase.testExecute.approved.txt 19bc3e7
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.java 0631996
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testBatch.approved.txt 9b4bb2f
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testPrepGit.approved.txt 2decd3e
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testPrepNone.approved.txt 7d8719d
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testPrepSvn.approved.txt 0af317e
testutils/ptest2/src/test/resources/TEST-SomeTest-success.xml PRE-CREATION
Diff: https://reviews.apache.org/r/12790/diff/
Testing
-------
This code is currently running in our ptest environment.
Thanks,
Brock Noland
Re: Review Request 12790: HIVE-4892: PTest2 cleanup after merge
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12790/
-----------------------------------------------------------
(Updated July 22, 2013, 6:23 p.m.)
Review request for hive.
Changes
-------
Removed and renamed the TEST-*.xml files we use for testing parsing of output files. This was causing issues with the build.
Bugs: HIVE-4892
https://issues.apache.org/jira/browse/HIVE-4892
Repository: hive-git
Description
-------
Fixes the following issues:
README is out of date
Need to limit the number of failed source directories we copy back from the slaves
when looking for TEST-*.xml files we look at both the log directory (good) and the failed source directories (bad) therefore duplicating failures in jenkins report
We need to process bad hosts in the finally block of PTest.run (HIVE-4882)
Need a mechanism to clean the ivy and maven cache (HIVE-4882)
PTest2 fails to publish a comment to a JIRA sometimes (HIVE-4889)
Now that PTest2 is committed to the source tree it's copying in our TEST-SomeTest*.xml files
Diffs (updated)
-----
testutils/ptest2/README.md a483851
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java d6e9ce3
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java b41726a
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java 9b2125c
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/ExecutionPhase.java b5d7909
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/HostExecutor.java 34a087c
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java 09c6d66
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JUnitReportParser.java 50cce25
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java f4f5076
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/ReportingPhase.java 023c26b
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/QFileTestBatch.java 722312a
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java fef2a3e
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/UnitTestBatch.java e911304
testutils/ptest2/src/main/resources/batch-exec.vm a35fcec
testutils/ptest2/src/main/resources/source-prep.vm 7a92272
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestExecutionPhase.java eec5560
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestHostExecutor.java 6fc649a
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestReportParser.java 61b345d
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestReportingPhase.testExecute.approved.txt 19bc3e7
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.java 0631996
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testBatch.approved.txt 9b4bb2f
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testPrepGit.approved.txt 2decd3e
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testPrepNone.approved.txt 7d8719d
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestScripts.testPrepSvn.approved.txt 0af317e
testutils/ptest2/src/test/resources/SomeTest-failure.xml PRE-CREATION
testutils/ptest2/src/test/resources/SomeTest-success.xml PRE-CREATION
testutils/ptest2/src/test/resources/TEST-SomeTest-failure.xml d033cc4
testutils/ptest2/src/test/resources/test-outputs/SomeTest-truncated.xml PRE-CREATION
testutils/ptest2/src/test/resources/test-outputs/TEST-SomeTest-truncated.xml 7e3fca4
testutils/ptest2/src/test/resources/test-outputs/TEST-index_auth.q-bucketcontex-ba31fb54-1d7f-4c70-a89d-477b7d155191-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml dcf4d4f
testutils/ptest2/src/test/resources/test-outputs/TEST-skewjoin.q-ab8536a7-1b5c-45ed-ba29-14450f27db8b-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml c7d5e9a
testutils/ptest2/src/test/resources/test-outputs/TEST-skewjoin_union_remove_1.q-6fa31776-d2b0-4e13-9761-11f750627ad1-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml fdf82c3
testutils/ptest2/src/test/resources/test-outputs/TEST-union_remove_9.q-acb9de8f-1b9c-4874-924c-b2107ca7b07c-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml fdddd36
testutils/ptest2/src/test/resources/test-outputs/index_auth.q-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml PRE-CREATION
testutils/ptest2/src/test/resources/test-outputs/index_auth.q-bucketcontex-ba31fb54-1d7f-4c70-a89d-477b7d155191-hive.log bf4e0a8
testutils/ptest2/src/test/resources/test-outputs/index_auth.q-hive.log PRE-CREATION
testutils/ptest2/src/test/resources/test-outputs/skewjoin.q-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml PRE-CREATION
testutils/ptest2/src/test/resources/test-outputs/skewjoin.q-ab8536a7-1b5c-45ed-ba29-14450f27db8b-TestCliDriver.txt d495d05
testutils/ptest2/src/test/resources/test-outputs/skewjoin.q-ab8536a7-1b5c-45ed-ba29-14450f27db8b-hive.log f483fb8
testutils/ptest2/src/test/resources/test-outputs/skewjoin_union_remove_1.q-6fa31776-d2b0-4e13-9761-11f750627ad1-TestCliDriver.txt 0f82789
testutils/ptest2/src/test/resources/test-outputs/skewjoin_union_remove_1.q-6fa31776-d2b0-4e13-9761-11f750627ad1-hive.log ebae0bf
testutils/ptest2/src/test/resources/test-outputs/skewjoin_union_remove_1.q-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml PRE-CREATION
testutils/ptest2/src/test/resources/test-outputs/skewjoin_union_remove_1.q-TestCliDriver.txt PRE-CREATION
testutils/ptest2/src/test/resources/test-outputs/union_remove_9.q-TEST-org.apache.hadoop.hive.cli.TestCliDriver.xml PRE-CREATION
testutils/ptest2/src/test/resources/test-outputs/union_remove_9.q-acb9de8f-1b9c-4874-924c-b2107ca7b07c-TestCliDriver.txt 6465594
testutils/ptest2/src/test/resources/test-outputs/union_remove_9.q-acb9de8f-1b9c-4874-924c-b2107ca7b07c-hive.log 7d7548c
Diff: https://reviews.apache.org/r/12790/diff/
Testing
-------
This code is currently running in our ptest environment.
Thanks,
Brock Noland