You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/10/22 11:33:24 UTC
[PR] fix: correct graph-space usage, quotas and removal [hugegraph]
imbajin opened a new pull request, #3391:
URL: https://github.com/apache/hugegraph/pull/3391
## Purpose of the PR
Graph-space cards can remain at zero after writes, newly bootstrapped DEFAULT spaces use effectively unlimited quotas, and peer Servers retain deleted spaces in their local caches.
## Main Changes
- Preserve reported usage when the PD REST/gRPC limit endpoints update a quota. Store limits in GB and merge KB usage under a lock shared by service facades, using exact-key reads. Refresh usage even without a Server configuration in the default cluster, count leader copies, and reset empty spaces to zero.
- Keep integer-GB `storage_used` for compatibility and add `storage_used_kb`; compute the ratio without prematurely rounding away small usage.
- Give new spaces, including DEFAULT, finite defaults: 128 CPU cores, 128 GB memory, 128 compute cores, 128 GB compute memory, 10240 GB storage, 100 graphs and 100 roles. Omitted API compute fields inherit the request's CPU/memory limits; explicit values, including zero's Kubernetes inheritance rule, are preserved. Existing persisted quotas are preserved.
- Register graph-space removal notifications and evict peer space/service caches without repeating destructive cleanup. Refresh a recreated space from current metadata and discard its old service cache when a delayed removal arrives.
Paired Toolchain PR: https://github.com/hugegraph/hugegraph-toolchain/pull/81
The Toolchain PR carries the optional usage field through the Java client and Hubble and updates the creation form/display.
## Verifying these changes
- [x] Added regression coverage: 8 Server tests and 5 PD tests pass, including cross-facade races, GB limit preservation, recreated-space cache replacement and API compute defaults.
- [x] `mvn editorconfig:format` and full `mvn clean compile -Dmaven.javadoc.skip=true` pass with JDK 17.
- [x] Targeted reactor tests: `GraphManagerClearGraphSpaceTest,GraphSpaceInfoLocaleTest,GraphSpaceUsageTest`, with `unit-test,pd-core-test`.
- Live multi-Server deployment testing was not run; peer notification behavior is covered with two manager replicas and captured metadata listeners.
## Does this PR potentially affect the following parts?
- [ ] Dependencies
- [x] Modify configurations: defaults for newly created spaces only
- [x] The public API: additive `storage_used_kb` response field and finite defaults for omitted creation resources
- [x] Other affects: metadata removal notifications
- [ ] Nope
## Documentation Status
- [x] Doc - Done: `docs/server-runtime.md`.
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
<!-- coderabbit-ai-generated:v1 -->
## Summary by CodeRabbit
* **功能**
* 图空间用量按分区 Leader 副本统计,并定期更新;无图空间时用量会更新为零。
* 图空间信息新增 KB 级精确用量和更精确的存储使用百分比;现有整数 GB 用量字段保留。
* 新建图空间采用有限资源默认值;修改存储限额时保留已有用量。
* 删除图空间后,各 Server 会清理本地缓存;若同名空间已重建,延迟的删除通知不会影响新空间。既有空间配置在重启后保留。
* **文档**
* 补充图空间存储用量统计、配额更新及删除行为说明。
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## 图解

图空间用量、配额与删除同步:Leader 副本近似用量经 Store 心跳与 PD 周期汇总上报;新空间采用有限默认配额;删除通知仅清理本地缓存,并保护同名重建空间。实现示意,不代表真实多 Server 验收通过。
---
Source community PR: https://github.com/hugegraph/hugegraph/pull/328. This upstream draft reuses the same branch. Figure PR numbers refer to that community source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: correct graph-space usage, quotas and removal [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #3391:
URL: https://github.com/apache/hugegraph/pull/3391#discussion_r4348242069
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java:
##########
@@ -2937,6 +2941,19 @@ private void loadAddedGraph(String graphName) {
}
}
+ private <T> void graphSpaceRemoveHandler(T response) {
+ for (String name : this.metaManager.extractGraphSpacesFromResponse(response)) {
+ GraphSpace current = this.metaManager.graphSpace(name);
+ if (current == null) {
+ this.graphSpaces.remove(name);
+ } else {
+ // A delayed REMOVE must refresh the recreated space rather than retain its old cache.
+ this.graphSpaces.put(name, current);
Review Comment:
[P2] Prevent delayed removal from overwriting a newer graph-space update
At reviewed head 8a966aad162f2113e76f6d4f0f3ad626c5215145, this handler can read metadata with max_graph_number=100, then a concurrent PUT can persist/cache max_graph_number=10, before this unconditional put restores the old snapshot. Subsequent createGraph() calls use that cached object and tryOfferGraph(), so this Server can admit graphs beyond the newly lowered graph-count limit, not merely display an old value. graphSpace() reloads only on a cache miss, and no graph-space add/update listener repairs the stale present entry.
Please sequence refresh with local mutations/publication or use a version-aware invalidation strategy, with a deterministic test pausing after the metadata read while a PUT completes. Identity-only compare-and-replace is insufficient because PUT mutates the cached GraphSpace in place.
Evidence boundary: independently cross-checked static interleaving, not a live multi-Server reproduction. This does not claim that the cache write directly changes already-applied PD storage or Kubernetes quotas.
Source: https://github.com/apache/hugegraph/blob/8a966aad162f2113e76f6d4f0f3ad626c5215145/hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java#L2944-L2954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: correct graph-space usage, quotas and removal [hugegraph]
Posted by "bitflicker64 (via GitHub)" <gi...@apache.org>.
bitflicker64 commented on code in PR #3391:
URL: https://github.com/apache/hugegraph/pull/3391#discussion_r4349470557
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/io/HugeGraphSONModule.java:
##########
@@ -369,6 +370,8 @@ public GraphSpace deserialize(JsonParser jsonParser,
memoryUsed = jsonParser.getNumberValue();
} else if ("storage_used".equals(fieldName)) {
storageUsed = jsonParser.getNumberValue();
+ } else if ("storage_used_kb".equals(fieldName)) {
+ storageUsedKb = jsonParser.getNumberValue();
Review Comment:
Important: Once a Server from before this PR rewrites a space record, this branch can no longer read it, and `GraphManager` init fails.
The new `info()` always writes `storage_used_kb`. The old deserializer stores unknown fields in `configs` via `getValueAsString()`, and the old `info()` writes `configs` back. Old Servers rewrite the record on `createGraph`, `dropGraph` and a space PUT, so the value becomes `"storage_used_kb":"524288"` and this line throws `Current token (VALUE_STRING) not numeric`. I reproduced it with master's and this branch's compiled `hugegraph-core`. `graphSpaceConfigs()` has no per-entry catch, and both `createDefaultGraphSpaceIfNeeded` and `loadGraphSpaces` call it, so one such record stops the whole Server. A rolling `helm upgrade` of the 3-replica Server Deployment can hit this, and so can a re-upgrade after `helm rollback`.
Fix: `storageUsedKb = jsonParser.getValueAsLong(-1);` (it also parses the string form), plus a round-trip test.
##########
hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/StoreNodeService.java:
##########
@@ -999,31 +1002,26 @@ public Map getQuota() throws PDException {
storages.put(graphSpace, size);
}
- Metapb.GraphSpace.Builder spaceBuilder = Metapb.GraphSpace.newBuilder();
HashMap<String, Boolean> limits = new HashMap<>();
for (Map.Entry<String, Long> item : storages.entrySet()) {
String spaceName = item.getKey();
+ long size = item.getValue();
String value = kvService.get(graphSpaceConfPrefix + spaceName);
+ boolean limited = false;
if (!StringUtils.isEmpty(value)) {
HashMap config = new Gson().fromJson(value, HashMap.class);
- Long size = item.getValue();
int limit = ((Double) config.get("storage_limit")).intValue();
- long limitByLong = limit * 1024L * 1024L;
- try {
- spaceBuilder.setName(spaceName).setStorageLimit(limitByLong).setUsedSize(size);
- Metapb.GraphSpace graphSpace = spaceBuilder.build();
- configService.setGraphSpace(graphSpace);
- } catch (Exception e) {
- log.error("update graph space with error:", e);
- }
- // KB and GB * 1024L * 1024L
- if (size > limitByLong) {
- limits.put(spaceName, true);
- continue;
- }
+ // Store statistics and PD graph-space usage are in KB; configuration is in GB.
+ long limitKb = limit * 1024L * 1024L;
+ limited = size > limitKb;
}
- limits.put(spaceName, false);
-
+ // Statistics must also advance when no Server config exists under the default cluster.
+ try {
+ configService.setGraphSpaceUsage(spaceName, size);
Review Comment:
Minor: Records written by an older PD keep their limit in KB, so PD reports mixed units after an upgrade.
The base `getQuota()` rewrote `storage_limit` as `limit * 1024 * 1024` every cycle for each space with a Server config. This loop now writes only usage and keeps the stored limit. So a 100 GB space carried over from the base still shows `storage_limit: 104857600` in PD `GET /graph-spaces`, while new spaces show 100. It stays that way until the space is next updated through the Server, since every space PUT calls `limitStorage`. Enforcement does not read this field, so only reporting is affected.
Please note in `docs/server-runtime.md` that one space PUT per space after the PD upgrade rewrites the limit in GB.
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/space/GraphSpaceAPI.java:
##########
@@ -415,15 +415,11 @@ public Map<String, Object> manage(@Context GraphManager manager,
exist.storageLimit = storageLimit;
}
- int computeCpuLimit = (int) graphSpaceMap
- .getOrDefault("compute_cpu_limit", 0);
- if (computeCpuLimit != 0) {
- exist.computeCpuLimit(computeCpuLimit);
+ if (graphSpaceMap.containsKey("compute_cpu_limit")) {
Review Comment:
Minor: The Java client always sends both compute fields, so a partial update now resets explicit compute limits to inherit.
`GraphSpace.GraphSpaceReq` in hugegraph-client (toolchain, `structure/space/GraphSpace.java`) copies `computeCpuLimit` and `computeMemoryLimit` as `int`, with no inclusion filter. An update built without them sends 0. Before this PR, 0 kept the stored value. Now `containsKey` is true and a stored 16 becomes 0. Read-modify-write callers are not affected, because GET returns the stored value. Apart from GET then reporting 0, the only effect is under `server.use_k8s`, where the compute quota falls back to `cpu_limit` and `memory_limit`.
Toolchain #834 fixes only Hubble (`GraphSpaceEntity.convertReq`). Moving that omission into `GraphSpaceReq` in #834 covers both callers, and the two PRs should then land together. Released clients still send 0, so please also note this in the upgrade docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: correct graph-space usage, quotas and removal [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #3391:
URL: https://github.com/apache/hugegraph/pull/3391#discussion_r4349879423
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/io/HugeGraphSONModule.java:
##########
@@ -369,6 +370,8 @@ public GraphSpace deserialize(JsonParser jsonParser,
memoryUsed = jsonParser.getNumberValue();
} else if ("storage_used".equals(fieldName)) {
storageUsed = jsonParser.getNumberValue();
+ } else if ("storage_used_kb".equals(fieldName)) {
+ storageUsedKb = jsonParser.getNumberValue();
Review Comment:
Rechecked at a13173dfa0613da99104dd1086a925ac1d0b43a7: the old-codec numeric-string rewrite is now accepted. Two independent reviews verified the exact parser and ran bounded JVM/Jackson cases covering zero, numeric strings, overflow, malformed optional precision and parser alignment; legacy GB fallback is preserved. The added frozen legacy-codec round trips and SpaceMetaManager startup-reader regression directly cover the reported path, but I inspected rather than independently executed the full Server suite. Current-head CI and full upgrade validation remain separate. This is targeted repair verification, not approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: correct graph-space usage, quotas and removal [hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3391:
URL: https://github.com/apache/hugegraph/pull/3391#issuecomment-6340120739
## [Codecov](https://app.codecov.io/gh/apache/hugegraph/pull/3391?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `84.00000%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.98%. Comparing base ([`c2ec570`](https://app.codecov.io/gh/apache/hugegraph/commit/c2ec5704332fc1102ad277d6aae6658d65c73601?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c53f739`](https://app.codecov.io/gh/apache/hugegraph/commit/c53f7394972ffc5c4d407a4da6fcc91d94007847?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hugegraph/pull/3391?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hugegraph/pd/StoreNodeService.java](https://app.codecov.io/gh/apache/hugegraph/pull/3391?src=pr&el=tree&filepath=hugegraph-pd%2Fhg-pd-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhugegraph%2Fpd%2FStoreNodeService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVnZWdyYXBoLXBkL2hnLXBkLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1Z2VncmFwaC9wZC9TdG9yZU5vZGVTZXJ2aWNlLmphdmE=) | 75.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hugegraph/pull/3391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hugegraph/pd/ConfigService.java](https://app.codecov.io/gh/apache/hugegraph/pull/3391?src=pr&el=tree&filepath=hugegraph-pd%2Fhg-pd-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhugegraph%2Fpd%2FConfigService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVnZWdyYXBoLXBkL2hnLXBkLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1Z2VncmFwaC9wZC9Db25maWdTZXJ2aWNlLmphdmE=) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hugegraph/pull/3391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3391 +/- ##
============================================
+ Coverage 55.93% 55.98% +0.05%
- Complexity 2277 2301 +24
============================================
Files 774 775 +1
Lines 68534 68493 -41
Branches 9333 9317 -16
============================================
+ Hits 38334 38348 +14
+ Misses 26634 26587 -47
+ Partials 3566 3558 -8
```
| [Flag](https://app.codecov.io/gh/apache/hugegraph/pull/3391/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [commons](https://app.codecov.io/gh/apache/hugegraph/pull/3391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.37% <ø> (ø)` | | Carriedforward from [941b0e7](https://app.codecov.io/gh/apache/hugegraph/commit/941b0e75dd38bd997e1b7333747b6b49e32bac9a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [hstore](https://app.codecov.io/gh/apache/hugegraph/pull/3391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.80% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [941b0e7](https://app.codecov.io/gh/apache/hugegraph/commit/941b0e75dd38bd997e1b7333747b6b49e32bac9a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pd](https://app.codecov.io/gh/apache/hugegraph/pull/3391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.17% <84.00%> (+0.99%)` | :arrow_up: | |
| [server_hbase](https://app.codecov.io/gh/apache/hugegraph/pull/3391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.85% <ø> (-0.05%)` | :arrow_down: | Carriedforward from [941b0e7](https://app.codecov.io/gh/apache/hugegraph/commit/941b0e75dd38bd997e1b7333747b6b49e32bac9a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [server_memory](https://app.codecov.io/gh/apache/hugegraph/pull/3391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.29% <ø> (-0.04%)` | :arrow_down: | Carriedforward from [941b0e7](https://app.codecov.io/gh/apache/hugegraph/commit/941b0e75dd38bd997e1b7333747b6b49e32bac9a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [server_rocksdb](https://app.codecov.io/gh/apache/hugegraph/pull/3391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.29% <ø> (-0.05%)` | :arrow_down: | Carriedforward from [941b0e7](https://app.codecov.io/gh/apache/hugegraph/commit/941b0e75dd38bd997e1b7333747b6b49e32bac9a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [store](https://app.codecov.io/gh/apache/hugegraph/pull/3391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.93% <ø> (ø)` | | Carriedforward from [941b0e7](https://app.codecov.io/gh/apache/hugegraph/commit/941b0e75dd38bd997e1b7333747b6b49e32bac9a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph/pull/3391?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: correct graph-space usage, quotas and removal [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #3391:
URL: https://github.com/apache/hugegraph/pull/3391#discussion_r4348447480
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java:
##########
@@ -2937,6 +2941,19 @@ private void loadAddedGraph(String graphName) {
}
}
+ private <T> void graphSpaceRemoveHandler(T response) {
+ for (String name : this.metaManager.extractGraphSpacesFromResponse(response)) {
+ GraphSpace current = this.metaManager.graphSpace(name);
+ if (current == null) {
+ this.graphSpaces.remove(name);
+ } else {
+ // A delayed REMOVE must refresh the recreated space rather than retain its old cache.
+ this.graphSpaces.put(name, current);
Review Comment:
Rechecked at 09625220107648c8b957dd87dcc13938ec4b997a: the reported completed-PUT overwrite race is addressed. Cache publication now advances a monitor-protected version even for the same GraphSpace instance; a refresh retries a metadata snapshot if a local publication occurred meanwhile. Metadata IO remains outside the monitor. Two independent static reviews found no missed direct cache-write path.
I also ran the exact extracted cache methods in a bounded Java harness: delayed refresh versus same-instance completed update and versus deletion both retained the newer result and retried once. The added barrier tests exercise the actual API update and graph-limit enforcement paths, but I have not independently run those full Server tests. This updates the conclusion for this specific race only; CI and end-to-end performance acceptance remain separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: correct graph-space usage, quotas and removal [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #3391:
URL: https://github.com/apache/hugegraph/pull/3391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org